Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEFswift cannot be distributed as a self-contained framework #38

Open
SyberToto opened this issue May 14, 2019 · 3 comments
Open

CEFswift cannot be distributed as a self-contained framework #38

SyberToto opened this issue May 14, 2019 · 3 comments

Comments

@SyberToto
Copy link

Currently, CEFswift is using a module map to access Chromium Embedded framework itself, but that module map is not included in CEFswift.framework. If any user wants to use compiled CEFswift.framework directly, s/he will probably meet such error

<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "Headers/CEFswift.h"
        ^
~/playground/CEF.swift/Samples/CEFDemo/Library/Release/CEFswift.framework/Headers/CEFswift.h:19:9: error: module 'ChromiumEmbedded' not found
@import ChromiumEmbedded;
        ^
<unknown>:0: error: could not build Objective-C module 'CEFswift'

To reproduce this error, just compile CEFswift and remove the modules folder in CEFswift's source code, then compile the sample project.

I'm not sure if it's a common practice to include multiple module map into one single framework, or should we just define both CEFswift and ChromiumEmbedded in the same module map for CEFswift.framework itself? Anyway, I guess the compiled framework shouldn't rely on any source code.

@lvsti
Copy link
Owner

lvsti commented May 17, 2019

Anyway, I guess the compiled framework shouldn't rely on any source code.

Completely agree and it came to me as a surprise that the headers must be present, but right now I don't have a solution off the top of my head. I'll give it a thought soon but if you can come up with something, I'm gladly accepting PRs.

@umairzahid508
Copy link

Did you find the solution for it ?

@Hesham-Salama
Copy link

Same issue. Can't be distributed. Hard link to the directory where it's built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants