Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change binding.gyp for mac for build the package #143

Open
gentilmente opened this issue Nov 13, 2021 · 1 comment
Open

change binding.gyp for mac for build the package #143

gentilmente opened this issue Nov 13, 2021 · 1 comment

Comments

@gentilmente
Copy link

I`m not an expert, sorry if this is not the correct way of ask for this change. It solved me a building problem.

'cflags': [ '--std=c++11' ],

'OTHER_CPLUSPLUSFLAGS' : [ '-std=c++11',

In both cases change it to 14

My system:
mac osx 12.0.1
updated xcode cli tools
node 14.16.0

@gentilmente gentilmente changed the title change binding.gyp for mac building the package change binding.gyp for mac for build the package Nov 13, 2021
@gentilmente
Copy link
Author

In the same direction, in order to be able to upgrade node to v16 you need to folow these instructions
https://github.com/electron/electron/issues/18397
in bining.cc:

extern "C" {
  NAN_MODULE_INIT(init) {
    Nan::HandleScope scope;
    GPhoto2::Initialize(target);
    GPCamera::Initialize(target);
  }

  #if NODE_MAJOR_VERSION >= 10
  NAN_MODULE_WORKER_ENABLED(gphoto2, init)
  #else
  NODE_MODULE(gphoto2, init)
  #endif
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant