Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future request / issue report: care about packet reordering #75

Open
cyanide-burnout opened this issue Jan 15, 2018 · 3 comments
Open

Comments

@cyanide-burnout
Copy link

cyanide-burnout commented Jan 15, 2018

Existing implementations of CPacketStream and CPacketQueue don't care about probabilistic reordering of UDP packets. Normally it should care about sequence numbers to process audio frames on the right order.

@LX3JL
Copy link
Owner

LX3JL commented Mar 16, 2019

This is actually the job of the repeaters/hotspot.
Indeed, even if xlx reorder udp packet before forwaring them to clients, there are no
garanties that they will not be scrambled again on their way to the final destination.

@cyanide-burnout
Copy link
Author

cyanide-burnout commented Mar 17, 2019

I cannot be agree with your point. In case when xlxd does transcoding it changes sequence numbers from D-STAR’s resolution of 21 numbers per sequence to at least MMDVM’s resolution of 256 numbers per sequence. In this case you breake a sequence. Also AMBE has a statefull algorithm and you have to provide frames to it in a proper sequence.

@cyanide-burnout
Copy link
Author

cyanide-burnout commented Mar 17, 2019

So I meant that not only repeaters/hotspots should care about sequence but xlxd too. Anyway its up to you to improve a product or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants