Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PutContainer/GetContainer to something makes more sense #15

Closed
caglar10ur opened this issue Oct 1, 2014 · 3 comments · Fixed by #17
Closed

Rename PutContainer/GetContainer to something makes more sense #15

caglar10ur opened this issue Oct 1, 2014 · 3 comments · Fixed by #17

Comments

@caglar10ur
Copy link
Member

Acquire / Release could be an option.
caglar10ur added a commit to caglar10ur/go-lxc that referenced this issue Oct 1, 2014
@caglar10ur
rename {Get/Put}Container to Acquire/Release - fixes lxc#15
ec940a5
@caglar10ur caglar10ur mentioned this issue Oct 1, 2014
Merged
@caglar10ur
Copy link
Member Author

@dcramer would you oppose me pushing something like this to v2 branch? Do you think naming is appropriate?

@dcramer
Copy link
Contributor

dcramer commented Oct 3, 2014

I think this is good. I was confused as to what PutContainer was until I read the doc on it

@caglar10ur
Copy link
Member Author

OK, closing this as I just merged it into v2...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename {Get/Put}Container to Acquire/Release caglar10ur/go-lxc
2 participants
@dcramer @caglar10ur