incus: Enable cobra's completion support #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
| @@ -274,9 +274,14 @@ For help with any of those, simply call them with --help.`)) | |||
| if globalCmd.flagHelpAll { | |||
| // Show all commands | |||
| for _, cmd := range app.Commands() { | |||
| if cmd.Name() == "completion" { | |||
There was a problem hiding this comment.
This isn't necessary. go run ./cmd/incus --help --all | grep completion with just the hidden flag does not show the completion command.
There was a problem hiding this comment.
Yeah but that's because of our custom help template, that code would have otherwise been needed so I went for just making the logic consistent with the manpage one.
That way should we ever change the help template to something more standard we won't find ourselves with the command showing up.
|
Thanks for the quick change! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.