Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe-background.gif (question) #23

Closed
smaragdus opened this issue Jan 20, 2020 · 5 comments
Closed

iframe-background.gif (question) #23

smaragdus opened this issue Jan 20, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@smaragdus
Copy link

Hello,

When I use Image Downloader Continued (Chrome Web Store, GitHub), an extension which extracts all image files found in a web page, it also gets a GIF file:

iframe-background.gif

which turned out to be a part of Vertical Tabs extension, screen:

Image Downloader Continued 2 8 - 2020-01-20 - 003

This file appears every time I extract images using Image Downloader Continued and I find this a bit annoying. Can you confirm this? Is there any workaround? Is this file (iframe-background.gif) needed for Vertical Tabs to function properly?

lxieyang added a commit that referenced this issue Jan 20, 2020
@lxieyang lxieyang self-assigned this Jan 20, 2020
@lxieyang lxieyang added the enhancement New feature or request label Jan 20, 2020
@lxieyang
Copy link
Owner

Hi, thanks for reporting the issue! A fix has been implemented and pushed to the Chrome Web Store. Please expect an update in about a week.

Also, thanks so much for trying this extension out! It really means the world to me!

@smaragdus
Copy link
Author

@lxieyang

Thank you for the extremely quick response and fix! You are very helpful as usual!

I have several ideas for possible enhancements but before suggesting anything I would like to know whether you would like to keep your extension as simple as possible or you don't mind adding new features? Also- which would be better- to suggest ideas in separate issues or in a single issue?

Regards

@lxieyang
Copy link
Owner

lxieyang commented Jan 20, 2020

Please feel free to open up separate issues describing your ideas! My original intention was to keep the extension as a minimalistic one. However, my current thoughts are:

  • add interesting and useful new features
  • give the users control in terms of what are the features they would like to enable in the settings menu
    Therefore, please don't hesitate to contribute new ideas and I'll do my best to assess them and make them happen asap!

@lxieyang
Copy link
Owner

@smaragdus v1.6.1 is live on the Chrome Web Store. Please update and see if the bug has been fixed. Thanks!

@smaragdus
Copy link
Author

@lxieyang

I got version 1.6.1 of Vertical Tabs through Chrome Web Store and I can confirm that the file I mentioned above (iframe-background.gif) no longer appears in the extracted images, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants