Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen daemon #626

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Screen daemon #626

wants to merge 2 commits into from

Conversation

selairi
Copy link
Contributor

@selairi selairi commented May 17, 2020

Simple screen daemon. Related to: lxqt/lxqt#1788

@yan12125
Copy link
Member

Seems lxqt-monitor/UdevNotifier.* are the same as lxqt-session/src/UdevNotifier.*? If so, it will be better to keep that class in one place. Maybe liblxqt.

@tsujan
Copy link
Member

tsujan commented May 18, 2020

I guess they're meant to be removed from lxqt-session in another PR. @selairi, am I right?

it will be better to keep that class in one place. Maybe liblxqt.

I'm not sure. If they had other purposes, yes. But they're only about monitors. So, IMHO, this place is OK. Maybe it's a habit but I'm more comfortable when I find things that are related to each other in one place; in this case, the current place.

@yan12125
Copy link
Member

Well, UdevNotifier class is still used in lxqt-session for detecting new input devices and loading keyboard settings - https://github.com/lxqt/lxqt-session/blob/784acb78587c72c7f77dbf8878ef4d51bdffb938/lxqt-session/src/sessionapplication.cpp#L84 (maybe that should be moved from lxqt-session to a standalone daemon, too?)

@tsujan
Copy link
Member

tsujan commented May 18, 2020

@yan12125
I missed that. You're right; liblxqt may be the best choice then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants