"Modernize" the shortcut editor

[tsujan]

Qt can handle that now.

NOTE: The same thing should be done in all parts of LXQt, IMO. Those shortcut editors may have been the best choice before -- although I don't think so -- but not anymore.

[agaida]

So changing this and having a reference implementation is a good thing.

[tsujan]

Did it for QTerminal before.

[agaida]

fine

[shlyakpavel]

Did it for QTerminal before.

Is that what you mean? lxqt/qterminal#398

[tsujan]

Yes, actually https://github.com/lxqt/qterminal/pull/399/files. A more advanced version of it -- with ambiguity warnings and reserved shortcuts -- is in FeatherPad but QTerminal's shortcut editor is enough.

[shlyakpavel]

Yes, actually https://github.com/lxqt/qterminal/pull/399/files. A more advanced version of it -- with ambiguity warnings and reserved shortcuts -- is in FeatherPad but QTerminal's shortcut editor is enough.

The one in FeatherPad was too shocking for me... It is not a Qt way to do things. Hardcored keys, for example, are quite a bad idea... For example
tsujan/FeatherPad#221 (comment)

[tsujan]

It is not a Qt way to do things.

I respect Qt ways, more or less, in LXQt but, in my own apps, I don't limit myself to "standards" because, most of the time, they aren't enough. That's a discussion for another time and another place...