Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lychee trys to parse math equation leading to erroneous error message. #1197

Closed
etpalmer63 opened this issue Aug 4, 2023 · 8 comments · Fixed by #1473
Closed

Lychee trys to parse math equation leading to erroneous error message. #1197

etpalmer63 opened this issue Aug 4, 2023 · 8 comments · Fixed by #1473
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed workaround

Comments

@etpalmer63
Copy link

For example:

$$
[\psi](\mathbf{L}) 
$$

Is interpreted as a link and checked, giving an erroneous error message.

Is there anyway to workaround this? -- Thank you!

@mre
Copy link
Member

mre commented Aug 4, 2023

I'm assuming that's inside a Markdown file?

Is there anyway to workaround this? -- Thank you!

Well, you can exclude it with --exclude mathbf until we fixed the bug.

@mre mre added bug Something isn't working workaround labels Aug 4, 2023
@etpalmer63
Copy link
Author

etpalmer63 commented Aug 4, 2023

Ah thank you @mre ! I didn't realize the exclude would be that easy so I hadn't even looked yet. Thanks!

Also, yes. This is inside a Markdown file.

@HU90m
Copy link
Contributor

HU90m commented Jan 29, 2024

The solution to this bug is to support the maths syntax. We wouldn't really want to work out a spec and add custom parsers atop pulldown-cmark, so we are blocked on this being supported upstream.

It looks like there is some interest: pulldown-cmark/pulldown-cmark#622 rust-lang/mdBook#2222

As this bug has a workaround, I think it would be ok to close this issue with the stance that we will support maths syntax when pulldown-cmark does. Of course, discussion can still take place on the closed issue and it can be re-opened by anyone who wishes.

@mre I will leave closing this to you if you agree.

@mre
Copy link
Member

mre commented Jan 29, 2024

Good call. Seems like upstream process on this feature is slow, so might not make much sense to hold our breath before it lands. Closing. In case this gets merged in the future, I'd be thankful if someone could reopen the issue.

@mre mre closed this as completed Jan 29, 2024
@HU90m
Copy link
Contributor

HU90m commented Mar 29, 2024

pulldown-cmark/pulldown-cmark#734 (comment) 👀

@mre this could be re-opened

@mre mre reopened this Mar 29, 2024
@mre
Copy link
Member

mre commented Mar 29, 2024

Thanks for the notification.

@mre
Copy link
Member

mre commented Aug 6, 2024

👋 It got fixed by Hugo.

@etpalmer63
Copy link
Author

Thank you both for getting this done! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants