Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support several sort options for lookup history #385

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Conversation

lydavid
Copy link
Owner

@lydavid lydavid commented Aug 24, 2023

resolves #248

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (d9f35ad) 72.47% compared to head (9c0ff5a) 72.62%.
Report is 6 commits behind head on beta.

Additional details and impacted files
@@             Coverage Diff              @@
##               beta     #385      +/-   ##
============================================
+ Coverage     72.47%   72.62%   +0.14%     
  Complexity      280      280              
============================================
  Files           103      103              
  Lines          4622     4613       -9     
  Branches        767      758       -9     
============================================
  Hits           3350     3350              
  Misses          696      696              
+ Partials        576      567       -9     
Files Changed Coverage Δ
...ava/ly/david/mbjc/ui/navigation/NavigationGraph.kt 84.17% <ø> (+2.20%) ⬆️
...src/main/java/ly/david/mbjc/ui/TopLevelScaffold.kt 61.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

David Ly added 2 commits August 24, 2023 19:26
this also prevents crashing due to repeated separators
@lydavid lydavid marked this pull request as ready for review August 25, 2023 02:35
@lydavid lydavid merged commit 07a375c into beta Aug 25, 2023
3 checks passed
@lydavid lydavid deleted the dl/sort-history branch August 25, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort lookup history
1 participant