Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate retrofit to ktor for MusicBrainz module #396

Merged
merged 15 commits into from
Sep 1, 2023

Conversation

lydavid
Copy link
Owner

@lydavid lydavid commented Aug 31, 2023

resolves #373

@lydavid lydavid changed the title Dl/musicbrainz ktor chore: migrate MusicBrainz module to ktor Aug 31, 2023
@lydavid lydavid changed the title chore: migrate MusicBrainz module to ktor chore: migrate retrofit to ktor for MusicBrainz module Aug 31, 2023
@lydavid lydavid changed the title chore: migrate retrofit to ktor for MusicBrainz module feat: migrate retrofit to ktor for MusicBrainz module Aug 31, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 30.76% and project coverage change: +0.51% 🎉

Comparison is base (5156c51) 72.60% compared to head (3fee3e8) 73.12%.
Report is 1 commits behind head on beta.

❗ Current head 3fee3e8 differs from pull request most recent head ed152b9. Consider uploading reports for the commit ed152b9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               beta     #396      +/-   ##
============================================
+ Coverage     72.60%   73.12%   +0.51%     
+ Complexity      274      271       -3     
============================================
  Files           103      103              
  Lines          4610     4576      -34     
  Branches        758      757       -1     
============================================
- Hits           3347     3346       -1     
+ Misses          696      663      -33     
  Partials        567      567              
Files Changed Coverage Δ
...rc/main/java/ly/david/mbjc/ui/TopLevelViewModel.kt 44.20% <0.00%> (-1.39%) ⬇️
...ly/david/mbjc/ui/area/details/AreaDetailsScreen.kt 38.29% <0.00%> (ø)
...avid/mbjc/ui/artist/details/ArtistDetailsScreen.kt 44.28% <0.00%> (ø)
.../david/mbjc/ui/event/details/EventDetailsScreen.kt 23.33% <0.00%> (ø)
.../david/mbjc/ui/place/details/PlaceDetailsScreen.kt 58.82% <0.00%> (ø)
...id/mbjc/ui/release/details/ReleaseDetailsScreen.kt 37.93% <0.00%> (ø)
...ava/ly/david/mbjc/ui/area/AreaScaffoldViewModel.kt 94.73% <100.00%> (+6.93%) ⬆️
...ly/david/mbjc/ui/artist/ArtistScaffoldViewModel.kt 93.33% <100.00%> (+5.83%) ⬆️
...a/ly/david/mbjc/ui/event/EventScaffoldViewModel.kt 97.05% <100.00%> (+7.86%) ⬆️
...a/ly/david/mbjc/ui/genre/GenreScaffoldViewModel.kt 88.88% <100.00%> (+8.88%) ⬆️
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lydavid lydavid marked this pull request as ready for review September 1, 2023 12:15
@lydavid lydavid merged commit ef39a0e into beta Sep 1, 2023
1 check passed
@lydavid lydavid deleted the dl/musicbrainz-ktor branch September 1, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate retrofit to ktor for multiplatform network
1 participant