Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to create index on AWSPrincipal and not Principal #11

Closed
achantavy opened this issue Mar 7, 2019 · 3 comments
Closed

Need to create index on AWSPrincipal and not Principal #11

achantavy opened this issue Mar 7, 2019 · 3 comments
Labels
schema Graph data schema issues

Comments

@achantavy
Copy link
Contributor

See https://github.com/lyft/cartography/blob/master/cartography/data/indexes.cypher#L37:

We create an index on a Principal node, but we don't ingest that anywhere. Perhaps this should be an AWSPrincipal instead?
@achantavy achantavy added the schema Graph data schema issues label Mar 28, 2019
@stale
Copy link

stale bot commented Sep 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale stalebot believes this issue/PR is no longer active label Sep 20, 2019
@stale
Copy link

stale bot commented Oct 4, 2019

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new change or reopen this one.

@stale stale bot closed this as completed Oct 4, 2019
@tobli tobli mentioned this issue Oct 5, 2019
Merged
@achantavy
Copy link
Contributor Author

Resolved in #175!

@achantavy achantavy removed the stale stalebot believes this issue/PR is no longer active label Oct 9, 2019
ramonpetgrave64 added a commit to neilroebert/cartography that referenced this issue Oct 24, 2023
@ramonpetgrave64
pin types-requests
3562252 
The new types-requests version is requiring urllib>2

```
cartography-cncf#11 59.90 Collecting urllib3>=2 (from types-requests->-r test-requirements.txt (line 8))
cartography-cncf#11 59.93   Downloading urllib3-2.0.7-py3-none-any.whl.metadata (6.6 kB)
```

* https://github.com/typeshed-internal/stub_uploader/blob/main/data/changelogs/requests.md#23107-2023-10-01
neilroebert pushed a commit to neilroebert/cartography that referenced this issue Oct 25, 2023
@ramonpetgrave64 @neilroebert
pin types-requests
65739ba 
The new types-requests version is requiring urllib>2

```
cartography-cncf#11 59.90 Collecting urllib3>=2 (from types-requests->-r test-requirements.txt (line 8))
cartography-cncf#11 59.93   Downloading urllib3-2.0.7-py3-none-any.whl.metadata (6.6 kB)
```

* https://github.com/typeshed-internal/stub_uploader/blob/main/data/changelogs/requests.md#23107-2023-10-01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
schema Graph data schema issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achantavy