Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadUnliftIO? #86

Open
MichaelXavier opened this issue Apr 4, 2019 · 1 comment
Open

MonadUnliftIO? #86

MichaelXavier opened this issue Apr 4, 2019 · 1 comment

Comments

@MichaelXavier
Copy link

It's looking like the ecosystem is moving away from MonadBaseControl IO and towards MonadUnliftIO, e.g. resourcet has completely moved over. It seems a lot easier to reason about and maps cleanly onto reader monad transformer stacks. One potential downside is that by design it isn't meant to be used in monads with non-deterministic exit points like ExceptT or StateT but I don't think that should be relevant to this library. I'm wondering if you'd be amenable to a PR that would try to exchange MonadBaseControl IO for MonadUnliftIO across the board. There's more documentation about it here. Thanks!
@lykahb
Copy link
Owner

lykahb commented Apr 8, 2019

That is a good idea - MonadBaseControl has always been hard to understand. I'd appreciate a PR replacing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelXavier @lykahb