Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’‘ Create IconCaption atom #215

Closed
CruuzAzul opened this issue Mar 26, 2023 · 0 comments Β· Fixed by #237
Closed

πŸ’‘ Create IconCaption atom #215

CruuzAzul opened this issue Mar 26, 2023 · 0 comments Β· Fixed by #237

Comments

@CruuzAzul
Copy link
Member

CruuzAzul commented Mar 26, 2023

Feature Request πŸ‘¨πŸΌβ€πŸ’»

We want to create a new IconCaption atom to be used in our compositions

Use Case ✍🏼

In many compositions we currently display information for conferences in the form of an icon and a corresponding caption (e.g. Devoxx). We want to have a component that displays an icon and a text.

Possible Solution πŸ’‘

We don't know yet if we want to make one atom for the icon version and another for the lottie version. We should see if it is possible to make one for both. If it is not possible, or if the atom becomes too complex, we will make two different atoms

ℹ️ Once this is done, update the different templates

@CruuzAzul CruuzAzul added the ✍🏼 In specification Needs more informations label Mar 26, 2023
@CruuzAzul CruuzAzul changed the title πŸ’‘ Create AssetCaption atom πŸ’‘ Create IconCaption atom Mar 26, 2023
@CruuzAzul CruuzAzul added 🏁 Ready to start You can take it ! and removed ✍🏼 In specification Needs more informations labels Mar 26, 2023
@Boyadjie Boyadjie linked a pull request Apr 4, 2023 that will close this issue
@Boyadjie Boyadjie added 🀝 Help wanted Extra attention is needed and removed 🏁 Ready to start You can take it ! labels Apr 5, 2023
@Boyadjie Boyadjie self-assigned this Apr 5, 2023
@Boyadjie Boyadjie added πŸ“š Ready for review and removed 🀝 Help wanted Extra attention is needed labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants