Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed log messages and messed up their order on discord #244

Closed
xadll opened this issue Jan 21, 2024 · 3 comments
Closed

Missed log messages and messed up their order on discord #244

xadll opened this issue Jan 21, 2024 · 3 comments
Assignees
Labels
not our bug We didn't break this

Comments

@xadll
Copy link

xadll commented Jan 21, 2024

ENV

      LOG_LEVEL: 5
      DISCORD_LOG_ENABLED: "YES"
      DISCORD_LOG_LEVEL: 5

File log in comparison to Discord log

{number}

  • the order in which the discord log was displayed

{--}

  • log that didn't show up on discord at all
{01} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:09] (ChatService.ts:78) player (player) used command /l
{02} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:09] (PopupWindow.ts:82) Player player (player) opened MapList manialink.
{03} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:13] (MapService.ts:335) player (player) removed map C13-Race by Nadeo
{05} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:13] (MapService.ts:436) player (player) removed map C13-Race by Nadeo from the queue
{04} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:13] (MapService.ts:398) Next map set to C02-Race by Nadeo 
{08} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:14] (MapService.ts:335) player (player) removed map C08-Obstacle by Nadeo
{06} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:14] (MapService.ts:436) player (player) removed map C08-Obstacle by Nadeo from the queue
{07} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:14] (MapService.ts:398) Next map set to C02-Race by Nadeo 
{09} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:15] (MapService.ts:335) player (player) removed map C02-Race by Nadeo
{10} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:15] (MapService.ts:436) player (player) removed map C02-Race by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:15] (MapService.ts:398) Next map set to C11-Race by Nadeo 
{11} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:16] (MapService.ts:335) player (player) removed map C03-Acrobatic by Nadeo
{12} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:16] (MapService.ts:436) player (player) removed map C03-Acrobatic by Nadeo from the queue
{13} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:16] (MapService.ts:398) Next map set to C11-Race by Nadeo 
{15} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:16] (MapService.ts:335) player (player) removed map C04-Race by Nadeo
{14} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:16] (MapService.ts:436) player (player) removed map C04-Race by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:17] (MapService.ts:398) Next map set to C11-Race by Nadeo 
{--} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:17] (MapService.ts:335) player (player) removed map C05-Endurance by Nadeo
{16} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:17] (MapService.ts:436) player (player) removed map C05-Endurance by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:17] (MapService.ts:398) Next map set to C11-Race by Nadeo 
{18} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:18] (MapService.ts:335) player (player) removed map C06-Speed by Nadeo
{17} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:18] (MapService.ts:436) player (player) removed map C06-Speed by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:18] (MapService.ts:398) Next map set to C11-Race by Nadeo 
{--} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:18] (MapService.ts:335) player (player) removed map C07-Race by Nadeo
{18} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:18] (MapService.ts:436) player (player) removed map C07-Race by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:18] (MapService.ts:398) Next map set to C11-Race by Nadeo 
{--} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:19] (MapService.ts:335) player (player) removed map C09-Race by Nadeo
{19} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:19] (MapService.ts:436) player (player) removed map C09-Race by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:19] (MapService.ts:398) Next map set to C11-Race by Nadeo 
{--} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:19] (MapService.ts:335) player (player) removed map C10-Acrobatic by Nadeo
{20} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:19] (MapService.ts:436) player (player) removed map C10-Acrobatic by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:19] (MapService.ts:398) Next map set to C11-Race by Nadeo 
{--} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:20] (MapService.ts:335) player (player) removed map C11-Race by Nadeo
{21} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:20] (MapService.ts:436) player (player) removed map C11-Race by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:20] (MapService.ts:398) Next map set to C12-Obstacle by Nadeo 
{23} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:20] (MapService.ts:335) player (player) removed map C12-Obstacle by Nadeo
{22} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:20] (MapService.ts:436) player (player) removed map C12-Obstacle by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:20] (MapService.ts:398) Next map set to C14-Endurance by Nadeo 
{24} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:20] (MapService.ts:335) player (player) removed map C14-Endurance by Nadeo
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:20] (MapService.ts:436) player (player) removed map C14-Endurance by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:20] (MapService.ts:398) Next map set to C15-Speed by Nadeo 
{--} server  | 0|Trakman  | <INFO> [21 Jan 2024 11:23:21] (MapService.ts:335) player (player) removed map C15-Speed by Nadeo
{25} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:21] (MapService.ts:436) player (player) removed map C15-Speed by Nadeo from the queue
{--} server  | 0|Trakman  | <TRACE> [21 Jan 2024 11:23:21] (MapService.ts:398) Next map set to C01-Race by Nadeo 
@wsrvn
Copy link
Collaborator

wsrvn commented Jan 21, 2024

while this is far from ideal, i believe this cannot be truly fixed within our code. discord and cloudflare both have certain ratelimits for webhooks as mentioned here. if you want my 2 cents, it is also not a good practice to set the logging level to something other than info/warn, especially on webhook. the log order is likely messed up due to this as well (too many simultaneous requests on the api).

@xadll
Copy link
Author

xadll commented Jan 21, 2024

while this is far from ideal, i believe this cannot be truly fixed within our code. discord and cloudflare both have certain ratelimits for webhooks as mentioned here. if you want my 2 cents, it is also not a good practice to set the logging level to something other than info/warn, especially on webhook. the log order is likely messed up due to this as well (too many simultaneous requests on the api).

Good point.
Will it be left as it is, or will a change be made to not allow a higher loglevel by design?

@wsrvn
Copy link
Collaborator

wsrvn commented Jan 21, 2024

Good point.
Will it be left as it is, or will a change be made to not allow a higher loglevel by design?

i will likely reference this issue in the wiki for clarity (like what we do for the database stuff). i reckon it would be counterproductive to limit the values. after all, it is your server. if you really wish to have your webhook spammed, so be it.

@wsrvn wsrvn added the not our bug We didn't break this label Jan 21, 2024
@VTXSRB VTXSRB closed this as completed Feb 12, 2024
@VTXSRB VTXSRB reopened this Feb 12, 2024
@VTXSRB VTXSRB closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
Repository owner deleted a comment from wsrvn Feb 12, 2024
Repository owner deleted a comment from VTXSRB Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not our bug We didn't break this
Projects
None yet
Development

No branches or pull requests

3 participants