Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

NPM Publish in release.js config not working #42

Closed
offirgolan opened this issue Jan 17, 2016 · 6 comments
Closed

NPM Publish in release.js config not working #42

offirgolan opened this issue Jan 17, 2016 · 6 comments

Comments

@offirgolan
Copy link

Im on v1.0.0-beta.0 and this is my current config

/* jshint node:true */
/* var RSVP = require('rsvp'); */
var execSync = require('child_process').execSync;

module.exports = {
  publish: true,
  afterPublish: function(project, versions) {
    // Publish dummy app with docs to gh-pages
    runCommand('ember github-pages:commit --message "Released ' + versions.next + '"');
    runCommand('git push origin gh-pages:gh-pages');
  }
};

function runCommand(command) {
  console.log('running: ' + command);
  var output = execSync(command, { encoding: 'utf8' });
  console.log(output);
}

When I ran ember release it didnt publish or even go into the afterPublish hook.

master $> ember release
Warning: cannot specify option `publish` in config/release.js, ignoring
version: 1.13.13
Latest tag: v2.2.0
Successfully committed changes 'Released v2.2.1' locally.
[?] About to create tag 'v2.2.1' and push to remote 'origin', proceed?: Yes
Successfully created git tag 'v2.2.1' locally.
Successfully pushed 'v2.2.1' to remote 'origin'.
Successfully pushed 'master' to remote 'origin'.

Is there something im missing?

@slindberg
Copy link
Contributor

That's a bug, fixed in #43

@slindberg
Copy link
Contributor

Released in 1.0.0-beta.1

@offirgolan
Copy link
Author

Thanks for the fix @slindberg 😸

@offirgolan
Copy link
Author

1.0.0-beta.1 not on npm 😢

@slindberg
Copy link
Contributor

Gah, sorry about that. Published now.

@offirgolan
Copy link
Author

Haha thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants