Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable d3d11 by disabling the SIRV meson patch #2358

Open
RivenSkaye opened this issue Jan 5, 2023 · 0 comments
Open

Enable d3d11 by disabling the SIRV meson patch #2358

RivenSkaye opened this issue Jan 5, 2023 · 0 comments

Comments

@RivenSkaye
Copy link
Contributor

RivenSkaye commented Jan 5, 2023

Currently the build process for SPIRV-Cross is being done with a (rather old) patch being pulled in to enable Meson builds for it. The patch does not offer all of the same options as the CMAKE files do, however, disabling the build of spirv-cross-c-shared packages. Unfortunately, this also disables D3D11 support in mpv because that has a hard dependency on that lib.
It seems that spirv-cross-c-shared is not used anywhere else except for some more exotic ffmpeg configuration, but in order to support the d3d11 vo for mpv, it's perhaps better to either change up the Meson build files being patched in, or to change the SPIRV build process to use CMAKE instead.

The main workflow of the SPIRV repository builds all options, if a reference is needed for the different commands to run

Small edit: seems like the --enable-spirv-cross flag requires SPIRV-Cross-C-Shared as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant