Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Edit notes'-dialog shows blank shape behind text selection toolbar #343

Closed
min7-i opened this issue Jul 10, 2024 · 5 comments
Closed

'Edit notes'-dialog shows blank shape behind text selection toolbar #343

min7-i opened this issue Jul 10, 2024 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@min7-i
Copy link

min7-i commented Jul 10, 2024

Steps to reproduce

  1. Open the details of an event.
  2. Tap on 'Notes'.
  3. Enter a text.
  4. Long-press the entered text to highlight it.

Expected behavior

The text selection toolbar is displayed.

Actual behavior

The text selection toolbar is displayed, but a blank shape is visible behind the toolbar and in front of the note dialog partially covering the actual note.

birday_e.mp4

Birday version

4.4.3 (F-Droid)

Devices

Google Pixel 6a Android 14 (GrapheneOS) | LG G6 Android 9

Other details

On my LG I also tested the versions 4.2.0 and 4.3.0 where the issue can be reproduced as well.

@m-i-n-a-r
Copy link
Owner

Woah, that's the weirdest bug I've ever seen 😐
And I can recreate it as well! I'll fix it asap, thanks!

@m-i-n-a-r m-i-n-a-r added the bug Something isn't working label Jul 10, 2024
@m-i-n-a-r
Copy link
Owner

I'm still investigating, but I can't find a fix. It could depend on the Material Components Google library

@m-i-n-a-r m-i-n-a-r added the help wanted Extra attention is needed label Jul 13, 2024
@min7-i
Copy link
Author

min7-i commented Jul 13, 2024

I just had a look at it and I assume that this is caused by setting android:background for the MaterialAlertDialog styles:

<item name="android:background">?colorBackgroundFloating</item>

<item name="android:background">@drawable/dialog_bg_monet</item>

I only did a quick test and removing this at least resolved the issue both when using the Monet theme and other themes, but I didn't check any of the other dialogs which are probably influenced by that as well.

@m-i-n-a-r
Copy link
Owner

I just had a look at it and I assume that this is caused by setting android:background for the MaterialAlertDialog styles:

<item name="android:background">?colorBackgroundFloating</item>

<item name="android:background">@drawable/dialog_bg_monet</item>

I only did a quick test and removing this at least resolved the issue both when using the Monet theme and other themes, but I didn't check any of the other dialogs which are probably influenced by that as well.

Thanks, I had no clue it could be the issue, but you're right! I'll remove this color, even if I'm probably using it to theme the preference dialogs or something similar 😕

@m-i-n-a-r
Copy link
Owner

Fixed this and other theme-related bugs in b04dbb1 , it was harder than I expected 😥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants