Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cron job check_ip update datestore w/o updating memcache #125

Open
yachang opened this issue Mar 29, 2018 · 3 comments
Open

cron job check_ip update datestore w/o updating memcache #125

yachang opened this issue Mar 29, 2018 · 3 comments
Assignees

Comments

@yachang
Copy link
Contributor

yachang commented Mar 29, 2018

Which cause data discrepancy, and in the next minute, check_status cron job will use memcache to revert what check_ip did.

@yachang yachang changed the title crone job check_ip update datestore w/o updating memcache cron job check_ip update datestore w/o updating memcache Mar 29, 2018
@nkinkade
Copy link
Contributor

There is code in the class IPUpdateHandler to update memcache too.

https://github.com/m-lab/mlab-ns/blob/master/server/mlabns/handlers/update.py#L268

Are you saying that the code just isn't working (which is possible).

Also, is it possible that this issue is essentially a duplicate of #97? If so, maybe we close this issue and add further notes to #97?

@kokosta
Copy link

kokosta commented Apr 23, 2018

@kokosta kokosta added the 2 label Apr 30, 2018
@yachang
Copy link
Contributor Author

yachang commented Apr 30, 2018

Fixed by PR #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants