Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on connection failure when multiple servers are available. #67

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented Apr 21, 2022

Closes #58


This change is Reviewable

Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: - I updated the coveralls.io settings for ndt7-client-go to publish a summary to the PR (that was previously disabled) and when I manually went to check on this build to see whether the new changes were covered it seems that the top level files (ndt7.go) are not covered -- I'm not sure why... Doesn't have to be this PR but it would be worthwhile verifying that the primary library files are also included in the coverage reports/ unit testing - e.g. https://coveralls.io/builds/48452574

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@robertodauria
Copy link
Contributor Author

It seems top-level files aren't listed under the "Tree" tab, but they are in the "List" tab:

image

I was a bit surprised by that 100% since that's not what vscode tells me when enabling the coverage overlay. I think other packages (or main) are covering the few remaining paths, and the -coverpkg flag to go test allows a package's tests to cover code from a different package (basically treating the whole library as a single unit). Nice.

@robertodauria robertodauria merged commit f6e687a into master Apr 21, 2022
@robertodauria robertodauria deleted the sandbox-roberto-retry-loop branch April 21, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try next available server on doConnection failure
3 participants