Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove litescope references from UART #13

Closed
sbourdeauducq opened this issue May 9, 2015 · 7 comments
Closed

Remove litescope references from UART #13

sbourdeauducq opened this issue May 9, 2015 · 7 comments
Assignees

Comments

@sbourdeauducq
Copy link
Member

And do not call the WB bridge "frontend".

@enjoy-digital
Copy link
Contributor

I've tried to change this, hope it's better.

@sbourdeauducq
Copy link
Member Author

I don't think the name uart.wishbone is relevant. Those names should reflect the role that the UART has, either as a target device that receives the characters to write from a CPU through a bus (Wishbone, CSR, ...), or as an initiator device that masters a bus.

@sbourdeauducq
Copy link
Member Author

Maybe uart.UART for the normal CSR target peripheral (since this is the most common, default, assumed role of a UART in a SoC), and uart.bridge.Wishbone for the initiator/bridge.

@enjoy-digital
Copy link
Contributor

Thanks, so is it OK if I rename wishbone.py in bridge.py ? (I want to avoid creating a bridge directory for now since we only have a wishbone bridge, eventually later if we have others bridges (AXI, Avalon))

@sbourdeauducq
Copy link
Member Author

Sounds good.

@enjoy-digital
Copy link
Contributor

Done, thanks for the feedback!

@sbourdeauducq
Copy link
Member Author

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants