[Do not merge] Testing azure core 2.0 w/ logging policy #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-redding
commented
Jun 11, 2024
| @@ -12,29 +12,12 @@ namespace Azure.Core.Diagnostics | |||
| [EventSource(Name = EventSourceName)] | |||
| internal sealed class AzureCoreEventSource : AzureEventSource | |||
| { | |||
| private const string EventSourceName = "Azure-Core"; | |||
| private const string EventSourceName = "Azure-Core-ext"; | |||
There was a problem hiding this comment.
This will still work with AzureCoreEventListener while avoiding conflicts with the event source created for "Azure-Core" created inside of System.ClientModel. The downside is that anyone with filtering that they implement on their own in something like app insights could be broken if they do an equals check on the name itself rather than using traits or doing something like a contains/starts with check.
m-redding
commented
Jun 11, 2024
| @@ -46,7 +47,7 @@ protected ClientLoggingPolicy(string logName, string[]? logTraits = default, Log | |||
| _assemblyName = loggingOptions.LoggedClientAssemblyName; | |||
| _clientRequestIdHeaderName = loggingOptions.RequestIdHeaderName; | |||
| _isLoggingEnabled = loggingOptions.IsLoggingEnabled; | |||
| _sanitizer = new PipelineMessageSanitizer(loggingOptions.AllowedQueryParameters, loggingOptions.AllowedHeaderNames); | |||
| _sanitizer = new PipelineMessageSanitizer(loggingOptions.AllowedQueryParameters.ToArray(), loggingOptions.AllowedHeaderNames.ToArray()); | |||
There was a problem hiding this comment.
forgot to cherry pick this one - not actually part of these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.