Fix "folderId" propagation for "update_dashboard" #85
Conversation
When the "folderId" is not available within the dashboard payload, populate it from the nested "meta" object, if given. On the other hand, if it *is* given within the dashboard payload, it should take precedence.
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage ? 85.95%
=======================================
Files ? 16
Lines ? 641
Branches ? 0
=======================================
Hits ? 551
Misses ? 90
Partials ? 0 Continue to review full report at Codecov.
|
|
@m0nhawk could you please take a look? |
|
Dear Andrew, can I humbly ask you about the chore to look at this patch and eventually release a new version of Thank you very much in advance. With kind regards, |
|
Hi Andrew, I feel a bit bad for bugging you about his once more. Do you see any chance to integrate this patch and issue a new release? It would really be nice in order to be able to release a new version of grafana-wtf. With kind regards, |
|
@m0nhawk could you please take a look? |
|
Hi again, everyone who is tripped by this issue can use monkey-patching to work around it. See grafana-toolbox/grafana-wtf@b77f90b and feel free to reuse it in your code. With kind regards, |
|
Hi again, we integrated this patch into the With kind regards, |
Dear Andrew,
this fixes #82. Users reported the original flaw through grafana-toolbox/grafana-wtf#5.
When the
folderIdis not available within the dashboard payload, populate it from the nestedmetaobject, if given. On the other hand, if it is given within the dashboard payload, it should take precedence.I have added additional tests to verify this situation.
With kind regards,
Andreas.