Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Front End to React #45

Closed
M0nica opened this issue Oct 13, 2018 · 7 comments
Closed

Migrate Front End to React #45

M0nica opened this issue Oct 13, 2018 · 7 comments

Comments

@M0nica
Copy link
Owner

M0nica commented Oct 13, 2018

Want to switch from using plain HTML to using React for the front-end and continue using Python/Flask to handle the logic.

Depending on the approach this can/should be broken up into smaller tasks.

Related links:

@nickisaacs
Copy link

@M0nica
Can I pick this up?

@M0nica
Copy link
Owner Author

M0nica commented Oct 13, 2018

Sure that would be great @nickisaacs. Do you have any ideas for minimizing merge conflicts?

@nickisaacs
Copy link

@M0nica Do you have any existing merge conflicts?

@M0nica
Copy link
Owner Author

M0nica commented Oct 13, 2018

No, but I imagine that redoing the weather.html and other html files will introduce merge conflicts...although actually in React the extension is different so I guess it's more so making sure all of that gets migrated over as opposed to fixing actual merge conflicts.

@nickisaacs
Copy link

@M0nica
I wouldn't be working on the HTML. I'm creating a react application inside your project, and I will convert the python app to a pure API which will be consumed by the React application. So now you will need to start the python app, and run the react app as well.

@nickisaacs
Copy link

nickisaacs commented Oct 14, 2018

#49 @M0nica
The CI tests will fail since I have modified the APIs.

@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants