Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target platform does not contain commons.lang #203

Closed
Bananeweizen opened this issue Feb 6, 2019 · 1 comment
Closed

target platform does not contain commons.lang #203

Bananeweizen opened this issue Feb 6, 2019 · 1 comment

Comments

@Bananeweizen
Copy link
Contributor

Neither the Oxygen nor Photon .target files contain org.apache.commons.lang, but it is used in the checkstyle plugin. How does this compile for others?
There are multiple options for fixing this:

  • add Orbit to the URL list in the target files
  • recreate the targets from TPD files, which allow much better control of the content
    If you advise me on some preferred solution, I might be able to contribute it myself.

PS: Any objections to replacing commons.lang with commons.lang3 in the process?
@vorburger
Copy link
Member

How does this compile for others?

I'm not 100% sure the CLI mvn build actually uses the .target files... there is probably potential for some clean up.

PS: Any objections to replacing commons.lang with commons.lang3 in the process?

as long as everything still works, do whatever you think needs to be done / you feel like doing!

Bananeweizen added a commit to Bananeweizen/m2e-code-quality that referenced this issue Feb 6, 2019
@Bananeweizen
Fix m2e-code-quality#203: Have org.apache.commons.lang in targets
e45245c 
The POM repositories and the Eclipse targets are somewhat out of sync.
As a quickfix just add the missing bundle to the Eclipse target. In the
long run I suggest to use a .target file in the Maven build, too,
instead of fetching whatever is available on the repository URLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vorburger @Bananeweizen