Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/info002.phpt fails with PHP 7.4.0 #102

Closed
Whissi opened this issue Nov 28, 2019 · 2 comments
Closed

tests/info002.phpt fails with PHP 7.4.0 #102

Whissi opened this issue Nov 28, 2019 · 2 comments

Comments

@Whissi
Copy link
Contributor

Whissi commented Nov 28, 2019

---- EXPECTED OUTPUT
Test
http\Exception\BadMessageException: http\Message::__construct(): Failed to parse headers: unexpected character '\057' at pos 4 of 'HTTP/1.1 99 Apples in my Basket' in %sinfo002.php:%d
Stack trace:
#0 %sinfo002.php(%d): http\Message->__construct('HTTP/1.1 99 App...')
#1 %sinfo002.php(%d): {closure}()
#2 %sinfo002.php(%d): trap(Object(Closure))
#3 {main}
http\Exception\BadMessageException: http\Message::__construct(): Failed to parse headers: unexpected character '\040' at pos 7 of 'CONNECT HTTP/1.1' in %sinfo002.php:%d
Stack trace:
#0 %sinfo002.php(%d): http\Message->__construct('CONNECT HTTP/1....')
#1 %sinfo002.php(%d): {closure}()
#2 %sinfo002.php(%d): trap(Object(Closure))
#3 {main}
HTTP/1.1 200
CONNECT www.example.org:80 HTTP/1.1
===DONE===
---- ACTUAL OUTPUT
Test
http\Exception\BadMessageException: http\Message::__construct(): Failed to parse headers: unexpected character '\057' at pos 4 of 'HTTP/1.1 99 Apples in my Basket' in /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/info002.php:14
Stack trace:
#0 /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/info002.php(14): http\Message->__construct()
#1 /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/info002.php(7): {closure}()
#2 /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/info002.php(15): trap()
#3 {main}
http\Exception\BadMessageException: http\Message::__construct(): Failed to parse headers: unexpected character '\040' at pos 7 of 'CONNECT HTTP/1.1' in /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/info002.php:18
Stack trace:
#0 /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/info002.php(18): http\Message->__construct()
#1 /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/info002.php(7): {closure}()
#2 /var/tmp/portage/dev-php/pecl-http-3.2.3/work/php7.4/tests/info002.php(19): trap()
#3 {main}
HTTP/1.1 200
CONNECT www.example.org:80 HTTP/1.1
===DONE===
---- FAILED
@m6w6
Copy link
Owner

m6w6 commented Dec 2, 2019

Thank you for this report. Unfortunately you did not provide enough information to handle this bug, while the tests succeed on travis-ci: https://travis-ci.org/m6w6/ext-http/jobs/618250434

@m6w6 m6w6 closed this as completed Dec 2, 2019
@Whissi
Copy link
Contributor Author

Whissi commented Dec 2, 2019

This test depends on zend.exception_ignore_args = Off whereas I was testing with zend.exception_ignore_args = On. Could you please adjust test suite to enforce correct setting?

m6w6 added a commit that referenced this issue Dec 4, 2019
Tests were failing on systems with zend.exception_ignore_arg set.
Thanks to Thomas Deutschmann (@Whissi)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants