Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #03 - Sample State #4

Closed
11 tasks done
keginzburg opened this issue Feb 1, 2023 · 1 comment
Closed
11 tasks done

Issue #03 - Sample State #4

keginzburg opened this issue Feb 1, 2023 · 1 comment

Comments

@keginzburg
Copy link
Collaborator

Sample State

  • State shape is flat!
  • State's keys are camelCased
  • All keys within the values in the state are accessible in the schema
  • Correctly formatted
    • Sample state is rendered with triple backticks, and the language ```javascript...```). This will display the state as a code block instead of a giant line of text
    • Top level slices
      • entities
      • session
      • errors (here or in ui)
      • ui (if needed)
    • Should NOT have nested slices, aka comments inside of posts
    • Some info from other tables is ok, for instance:
    • the author username and imageurl for a post. basically any info that the user can't change
    • like count and a boolean on whether the user likes the post instead of a likes slice

Comments

  1. Looks solid! My only concern is that you should not reveal your users' session_token or password_digest within your frontend state. Nix those please, then feel free to close this issue.
@M8825
Copy link
Owner

M8825 commented Feb 2, 2023

  • DONE

@M8825 M8825 closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants