fix: property memory annotations #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does 2 things. First, it fixes a reported crash due to the MPAliasResponse NSString *errorResponse being marked as assign intead of copy (or strong), as well as fixing another potential instance of this that I found in MParticleOptions NSString *defaultAgent being marked as unsafe_unretained instead of copy (or strong). I changed both instances of this to copy. Second, it removes all uses of the assign and unsafe_unretained memory annotations on value types, as that is the only valid option (strong and weak cannot be used for value types) and is the default anyway. Looking at Apple’s UIView.h for example, they omit them as well.
peterjenkins
approved these changes
Apr 25, 2022
einsteinx2
added a commit
that referenced
this pull request
Apr 27, 2022
This commit does 2 things. First, it fixes a reported crash due to the MPAliasResponse NSString *errorResponse being marked as assign intead of copy (or strong), as well as fixing another potential instance of this that I found in MParticleOptions NSString *defaultAgent being marked as unsafe_unretained instead of copy (or strong). I changed both instances of this to copy. Second, it removes all uses of the assign and unsafe_unretained memory annotations on value types, as that is the only valid option (strong and weak cannot be used for value types) and is the default anyway. Looking at Apple’s UIView.h for example, they omit them as well.
einsteinx2
added a commit
that referenced
this pull request
May 16, 2022
This commit does 2 things. First, it fixes a reported crash due to the MPAliasResponse NSString *errorResponse being marked as assign intead of copy (or strong), as well as fixing another potential instance of this that I found in MParticleOptions NSString *defaultAgent being marked as unsafe_unretained instead of copy (or strong). I changed both instances of this to copy. Second, it removes all uses of the assign and unsafe_unretained memory annotations on value types, as that is the only valid option (strong and weak cannot be used for value types) and is the default anyway. Looking at Apple’s UIView.h for example, they omit them as well.
einsteinx2
added a commit
that referenced
this pull request
May 17, 2022
This commit does 2 things. First, it fixes a reported crash due to the MPAliasResponse NSString *errorResponse being marked as assign intead of copy (or strong), as well as fixing another potential instance of this that I found in MParticleOptions NSString *defaultAgent being marked as unsafe_unretained instead of copy (or strong). I changed both instances of this to copy. Second, it removes all uses of the assign and unsafe_unretained memory annotations on value types, as that is the only valid option (strong and weak cannot be used for value types) and is the default anyway. Looking at Apple’s UIView.h for example, they omit them as well.
mparticle-automation
added a commit
that referenced
this pull request
May 17, 2022
# [8.8.0](v8.7.0...v8.8.0) (2022-05-17) ### Bug Fixes * Fix Dereferenced Garbage Pointer ([#148](#148)) ([d2c58e1](d2c58e1)) * property memory annotations ([#146](#146)) ([c95ddf6](c95ddf6)) * update active kits header ([#147](#147)) ([d196723](d196723)) ### Features * add conformsToProtocol forwarding to MPAppDelegateProxy ([#144](#144)) ([40e517a](40e517a)) * add support for client side rules ([#151](#151)) ([6a93096](6a93096))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit does 2 things.
First, it fixes a reported crash due to the MPAliasResponse NSString *errorResponse being marked as assign intead of copy (or strong), as well as fixing another potential instance of this that I found in MParticleOptions NSString *defaultAgent being marked as unsafe_unretained instead of copy (or strong). I changed both instances of this to copy.
Second, it removes all uses of the assign and unsafe_unretained memory annotations on value types, as that is the only valid option (strong and weak cannot be used for value types) and is the default anyway. Looking at Apple’s UIView.h for example, they omit them as well.
Testing Plan
Ran unit tests for iOS and tvOS. The changes are all trivial and other than compiling and tests passing should only require code review.
Master Issue
Closes https://go.mparticle.com/work/SQDSDKS-3660