Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update active kits header #147

Merged
merged 5 commits into from
May 12, 2022

Conversation

willpassidomo
Copy link
Contributor

Summary

The "x-mp-kits" header field was previously sending a list of kits that were actively receiving events. Now it will send a list of kits that have been configured, even if they are not actively receiving events due to the SDK state. For Example, a kit that was shut down due to the current user's logged-in status not matching its configurations directive previous would not have been included in this list but now will be included

Testing Plan

Modified a few existing tests to include checks for the new [kjitContainer configuredKits] method where the results would differ from [kitContainer activeKits]. Also included a new unit test with a more focused scenario. Updated a networking tests to make sure the configuredKits method was properly being applied to x-mp-kits

Master Issue

Closes https://go.mparticle.com/work/SQDSDKS-3738

Related (Android) PR

mParticle/mparticle-android-sdk#126

This field was previously sending a list of kits that were activley receiving events. Now it will send a list of kits that have been configured, even if they are not activley receiving events due to the SDK state. For Example, a kit that was shut down due to the current user's logged-in status not matching its configurations directive previous would not have been included in this list but now will be included
@willpassidomo willpassidomo changed the title Fix: update active kits header fix: update active kits header Apr 26, 2022
@willpassidomo willpassidomo reopened this Apr 26, 2022
mParticle-Apple-SDK/Kits/MPKitContainer.mm Outdated Show resolved Hide resolved
mParticle-Apple-SDK/Network/MPURLRequestBuilder.m Outdated Show resolved Hide resolved
- configuredKitsRegistry nullability
- dot syntax over brackets
@willpassidomo
Copy link
Contributor Author

@einsteinx2 all updated now :) let me know how it looks

mParticle-Apple-SDK/Network/MPURLRequestBuilder.m Outdated Show resolved Hide resolved
mParticle-Apple-SDK/Kits/MPKitContainer.mm Outdated Show resolved Hide resolved
@willpassidomo
Copy link
Contributor Author

@einsteinx2 bump :)

Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the other line I mentioned in my last comment rather than ping-ponging back to you again for something so trivial. Looks good to me now, I have no more nitpicks left haha.

@einsteinx2 einsteinx2 merged commit c695878 into development May 12, 2022
@einsteinx2 einsteinx2 deleted the fix/SQDSDKS-3738-update-active-kits-header branch May 12, 2022 20:35
einsteinx2 pushed a commit that referenced this pull request May 16, 2022
The `x-mp-kits` header field was previously sending a list of kits that were actively receiving events. Now it will send a list of kits that have been configured, even if they are not actively receiving events due to the SDK state. For example, a kit that was shut down due to the current user's logged-in status not matching its configurations directive previous would not have been included in this list, but now will be included.
einsteinx2 pushed a commit that referenced this pull request May 17, 2022
The `x-mp-kits` header field was previously sending a list of kits that were actively receiving events. Now it will send a list of kits that have been configured, even if they are not actively receiving events due to the SDK state. For example, a kit that was shut down due to the current user's logged-in status not matching its configurations directive previous would not have been included in this list, but now will be included.
mparticle-automation added a commit that referenced this pull request May 17, 2022
# [8.8.0](v8.7.0...v8.8.0) (2022-05-17)

### Bug Fixes

* Fix Dereferenced Garbage Pointer ([#148](#148)) ([d2c58e1](d2c58e1))
* property memory annotations ([#146](#146)) ([c95ddf6](c95ddf6))
* update active kits header ([#147](#147)) ([d196723](d196723))

### Features

* add conformsToProtocol forwarding to MPAppDelegateProxy ([#144](#144)) ([40e517a](40e517a))
* add support for client side rules ([#151](#151)) ([6a93096](6a93096))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants