Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for client side rules #151

Merged
merged 1 commit into from
May 12, 2022

Conversation

peterjenkins
Copy link
Contributor

Summary

This PR implements support for allowing SDK batches of data to be passed through a customer callback where they can be modified or dropped.

Testing Plan

  • Unit testing
  • Manual testing

Master Issue

Closes https://go.mparticle.com/work/3733

@peterjenkins peterjenkins self-assigned this May 11, 2022
@peterjenkins peterjenkins changed the title feat: allow batch mutation feat: add support for client side rules May 11, 2022
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Simple, easy to understand and great notes in the header comments.

@peterjenkins peterjenkins force-pushed the feat/3733-allow-batch-mutation branch from 62f428b to 679fc67 Compare May 12, 2022 18:38
@peterjenkins peterjenkins force-pushed the feat/3733-allow-batch-mutation branch from 679fc67 to e7d0604 Compare May 12, 2022 18:50
@einsteinx2 einsteinx2 merged commit 0413fe8 into development May 12, 2022
@einsteinx2 einsteinx2 deleted the feat/3733-allow-batch-mutation branch May 12, 2022 20:23
mparticle-automation added a commit that referenced this pull request May 17, 2022
# [8.8.0](v8.7.0...v8.8.0) (2022-05-17)

### Bug Fixes

* Fix Dereferenced Garbage Pointer ([#148](#148)) ([d2c58e1](d2c58e1))
* property memory annotations ([#146](#146)) ([c95ddf6](c95ddf6))
* update active kits header ([#147](#147)) ([d196723](d196723))

### Features

* add conformsToProtocol forwarding to MPAppDelegateProxy ([#144](#144)) ([40e517a](40e517a))
* add support for client side rules ([#151](#151)) ([6a93096](6a93096))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants