fix: Fix Dereferenced Garbage Pointer #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einsteinx2
reviewed
May 3, 2022
|
I'm going to give this a deeper look later, am slammed rest of today. |
BrandonStalnaker
force-pushed
the
fix/3658-fix-Dereferenced-Garbage-Pointer
branch
from
771e5ba
to
2b19e62
Compare
BrandonStalnaker
force-pushed
the
fix/3658-fix-Dereferenced-Garbage-Pointer
branch
from
2b19e62
to
ed957b1
Compare
einsteinx2
approved these changes
May 12, 2022
There was a problem hiding this comment.
Changes look great, so nice to see how much cleaner the code is without all that unnecessary C++. Since we're not longer doing the thing that was causing the crash, hopefully this takes care of it.
I was going to spend some time and do some more C++ refactoring, but honestly I have no spare time right now, so I'll go ahead and approve this since that's really unrelated anyway.
einsteinx2
pushed a commit
that referenced
this pull request
May 16, 2022
einsteinx2
pushed a commit
that referenced
this pull request
May 17, 2022
mparticle-automation
added a commit
that referenced
this pull request
May 17, 2022
# [8.8.0](v8.7.0...v8.8.0) (2022-05-17) ### Bug Fixes * Fix Dereferenced Garbage Pointer ([#148](#148)) ([d2c58e1](d2c58e1)) * property memory annotations ([#146](#146)) ([c95ddf6](c95ddf6)) * update active kits header ([#147](#147)) ([d196723](d196723)) ### Features * add conformsToProtocol forwarding to MPAppDelegateProxy ([#144](#144)) ([40e517a](40e517a)) * add support for client side rules ([#151](#151)) ([6a93096](6a93096))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A pattern was being used where a static NSString is converted to a std::string via the UTF8String property of NSString, stored in a std::vector, and then retrieved via operator[]. This result is then copied into a new string at the call site, which is where the app crashes.
Master Issue
Closes https://mparticle-eng.atlassian.net/browse/SQDSDKS-3658?atlOrigin=eyJpIjoiY2Q0NmJiNTY1NzAyNGE0MzgxM2RmZGE0MjI4MzViMTciLCJwIjoiaiJ9