Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove deprecated iAd framework #279

Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix: Remove deprecated iAd framework #279

merged 3 commits into from
Jun 10, 2024

Conversation

einsteinx2
Copy link
Contributor

@einsteinx2 einsteinx2 commented Jun 7, 2024 •
edited
Loading

Summary

  • Remove deprecated and no longer functional iAd framework code
  • Replace unnecessary reflection with direct calls to AdServices framework (this is already guarded by the if (@available(14.3 check, so we can just call the method directly
  • Fixed incorrect passing of error pointer instead of memory address which had been obfuscated by the use of reflection

Testing Plan

  • Was this tested locally? If not, explain why.
  • Smoke test in iOS and tvOS test app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@einsteinx2 einsteinx2 mentioned this pull request Jun 7, 2024
Closed
@einsteinx2 einsteinx2 changed the base branch from main to development June 7, 2024 14:25
BrandonStalnaker
BrandonStalnaker approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a minor nitpick

mParticle-Apple-SDK/Utils/MPSearchAdsAttribution.m Outdated Show resolved Hide resolved
@einsteinx2 einsteinx2 merged commit 31b283c into development Jun 10, 2024
9 of 11 checks passed
@einsteinx2 einsteinx2 deleted the fix/6525-remove-deprecated-iAds-framework branch June 10, 2024 22:40
mparticle-automation added a commit that referenced this pull request Jun 10, 2024
@mparticle-automation
chore(release): 8.24.3 [skip ci]
21b9da9 
## [8.24.3](v8.24.2...v8.24.3) (2024-06-10)

### Bug Fixes

* Remove deprecated iAd framework ([#279](#279)) ([31b283c](31b283c))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.24.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@einsteinx2 @mparticle-automation @BrandonStalnaker