Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to customize name in the footer #90

Closed
cuducos opened this issue Aug 5, 2021 · 2 comments
Closed

Option to customize name in the footer #90

cuducos opened this issue Aug 5, 2021 · 2 comments

Comments

@cuducos
Copy link
Contributor

cuducos commented Aug 5, 2021

Is your feature request related to a problem?

Not a problem, just a new use case. Usually I don't use my (full) name in presentations, I tend to use my social network user handle instead — in my case, @cuducos instead of Eduardo Cuducos.

Describe the solution you'd like

I can open a PR to add a flag to overwrite the user name when used, e.g.:

# slides exmaple.md --name "@cuducos"

This would use @cuducos in the “footer” instead of the full name of the logged user. This logic can be wrapped in cmd/root.cmd using Cobra.

Describe alternatives you've considered

Maybe we could use another naming, such as --footer — what do you think?

@maaslalani
Copy link
Owner

maaslalani commented Aug 5, 2021

I proposed a solution to solve both this issue and #87

With #87 (comment)

Something like the following at the top of the slides.

---
theme: foo.json # this is already implemented
author: @cuducos
date: 1970-01-01
---

I think this approach is nicer than having to add CLI flags everytime.

@cuducos
Copy link
Contributor Author

cuducos commented Aug 5, 2021

Awesome! Closes #91

@cuducos cuducos closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants