Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading of images #132

Closed
benbrignell opened this issue Apr 23, 2015 · 3 comments
Closed

Lazy loading of images #132

benbrignell opened this issue Apr 23, 2015 · 3 comments
Assignees

Comments

@benbrignell
Copy link
Contributor

Lazy loading Enhancement

Now there's a lot more images on the examples page it would be a good idea to lazy load (or have a smarter way of loading) a large amount of images.

It would be nice to start collecting the images for all the other resources but it's probably going to get slow.

@whitingx
Copy link
Collaborator

whitingx commented May 6, 2015

Wonder if it would also be useful to automate this screenshot process for when new resources are added.

Could use one of the screenshot>image API services available (e.g. http://www.page2images.com/website_thumbnail_api_document) to remove the manual step of adding individual screenshots.

As this could be done off the URL used to link to the style guide resource it would have the benefit of being able to set a refresh time to ensure the screenshot is always up-to-date. Might also be possible to use this to highlight when resource URLs change - if the screenshot API fails the resource link could be checked/updated.

@benbrignell
Copy link
Contributor Author

@whitingx at a quick glance I'm not sure if this particular suggestion would be suitable, however a solution like this would be worth considering but I think it best sit as it's own issue/suggestion.

As for lazy loading @maban, as you've tagged this 'help wanted' I recently used this https://github.com/kaizau/Lazy-Load-Images-without-jQuery which was quite lightweight and has no dependencies, which I could use on styleguides if that's easier.

@maban maban removed the help wanted label Dec 30, 2016
@maban
Copy link
Owner

maban commented Dec 30, 2016

Done!

@maban maban closed this as completed Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants