Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not put node_modules in repo #31

Closed
COLABORATI opened this issue Apr 24, 2016 · 2 comments
Closed

Do not put node_modules in repo #31

COLABORATI opened this issue Apr 24, 2016 · 2 comments

Comments

@COLABORATI
Copy link

I do not see any reason why it is good to put node_modules into this repo, it would be better to put that directory into a .gitignore file.
@mkvlrn-cm42
Copy link

+1

@zyrolasting
Copy link

zyrolasting commented Nov 5, 2016 •
edited
Loading

Done. Opened pull request to this effect: #37 @mac81 please review?

@mac81 mac81 closed this as completed Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mac81 @zyrolasting @COLABORATI @mkvlrn-cm42