Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for analyzing SASS files #47

Merged
merged 3 commits into from
Aug 10, 2014
Merged

Add support for analyzing SASS files #47

merged 3 commits into from
Aug 10, 2014

Conversation

macbre
Copy link
Owner

@macbre macbre commented Aug 10, 2014

Resolves #3

macbre added a commit that referenced this pull request Aug 10, 2014
Add support for analyzing SASS files
@macbre macbre merged commit d58f647 into devel Aug 10, 2014
@macbre macbre deleted the sass-support branch August 10, 2014 13:17
@kangax
Copy link

kangax commented Dec 6, 2014

How would I use Sass file when running analyze-css as command line? Just giving it --file errors out. I tried --preprocessor sass but it didn't work.

@macbre
Copy link
Owner Author

macbre commented Dec 6, 2014

@kangax, the preprocessor is selected based on the file extension. Simply pass style.scss as --file option.

@kangax
Copy link

kangax commented Dec 6, 2014

That's what I did but nope:

> analyze-css --file app/assets/stylesheets/_base.sass
Error: CSS parsing failed: missing '{' @ 2156:1

@macbre
Copy link
Owner Author

macbre commented Dec 6, 2014

analyze-css uses node-sass npm module and it only supports files with SCSS syntax

@kangax
Copy link

kangax commented Dec 7, 2014

That's strange. According to one of their issues:

"Once #324 has shipped we'll have pretty much automatic support for .sass files thanks to https://github.com/hcatlin/libsass/pull/181/files by @mgreter."

In any case, it would be great if analyze-css could parse .sass files, as I know a lot of people still prefer that (original) syntax.

I can open a new issue.

@macbre
Copy link
Owner Author

macbre commented Dec 7, 2014

@kangax, thanks for looking into this. Please open a new issue to support *.sass files as well. We may need to upgrade node-sass version used by analyze-css

@kangax
Copy link

kangax commented Dec 7, 2014

Opened #79 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for analyzing SASS files
2 participants