Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using Github Actions and building with Docker 23 #29

Closed
tobiasc opened this issue Aug 4, 2023 · 3 comments
Closed

Error when using Github Actions and building with Docker 23 #29

tobiasc opened this issue Aug 4, 2023 · 3 comments

Comments

@tobiasc
Copy link
Contributor

tobiasc commented Aug 4, 2023

We encountered a build error when running Github Actions and building the Dockerfile with Docker 23.0.6, whereas it worked on Docker 20.10.25.
The error message read: ERROR: failed to get console: provided file is not a console

We didn't upgrade on purpose, as I'm not even sure where the Docker config is located, so this probably happened due to some other upgrade or rebuilt of upstream dependencies.

I wasn't able to find much/anything on this error specifically, but the Docker build flag TTY was mentioned in a few Stack Overflow posts that seemed vaguely related, eg. https://stackoverflow.com/questions/70855915/fix-panic-provided-file-is-not-a-console-from-docker-compose-in-github-action

I noticed that the TTY flag was used in this line: https://github.com/macbre/push-to-ghcr/blob/master/action.yml#L93

I forked the repo and tried removing that line and it worked. master...tobiasc:push-to-ghcr:master

Working (Docker 20)
Docker_20

Broken (Docker 23 + original repo)
Docker_23

Fixed (Docker 23 + forked with fix repo)
Docker_23_fixed

@macbre
Copy link
Owner

macbre commented Aug 4, 2023

Thanks, @tobiasc for the bug report and the screenshots!

@macbre
Copy link
Owner

macbre commented Aug 4, 2023

Resolved by #30

@macbre macbre closed this as completed Aug 4, 2023
@thomaspaulin
Copy link

thomaspaulin commented Aug 22, 2023

I'm still seeing this today using master.

  docker_publish:
    runs-on: "ubuntu-20.04"
    steps:
      - name: Build and publish a Docker image for ${{ github.repository }}
        uses: macbre/push-to-ghcr@master
        with:
          image_name: ${{ github.repository }}
          image_tag: $(date +%s)
          github_token: ${{ secrets.GITHUB_TOKEN }}

push-to-ghcr-fail

EDIT: I opened #33 to raise visibility into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants