-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving subqueries columns #154
Conversation
or self.previous_token.normalized == "AS" | ||
or self.is_in_with_columns | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
or (self.previous_token.value == "(") | ||
and self.next_token.value == ")" | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
I realized that I forgot about with queries -> so that's also something that needs to be developed later (resolving with queries). |
**Extracts column names and tables** used by the query. | ||
Automatically conduct **column alias resolution**, **sub queries aliases resolution** as well as **tables aliases resolving**. | ||
|
||
Provides also a helper for **normalization of SQL queries**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
@macbre - now after coverage add the test pipeline fails with lack of GITHUB_TOKEN |
@macbre - Ok I fixed the coverall runs, do you need me to do anything more for this PR? |
Co-authored-by: Maciej Brencz <maciej.brencz@gmail.com>
Final piece of work in regard of resolving aliases and columns coming from sub-queries to the actual database columns.
Now all aliases should resolve and only real columns should be included in columns and columns_dict.
Following the updated readme note the tables in join:
Let me know what you think :)