Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for create table with with clause #157

Merged
merged 7 commits into from
Jun 9, 2021
Merged

Fix for create table with with clause #157

merged 7 commits into from
Jun 9, 2021

Conversation

collerek
Copy link
Collaborator

@collerek collerek commented Jun 3, 2021

Close: #155

@collerek collerek added the bug label Jun 3, 2021
@collerek collerek added this to the v2.2 milestone Jun 3, 2021
@collerek
Copy link
Collaborator Author

collerek commented Jun 3, 2021

I branched it from resolve_subqueries (#154) so after we merge that one this one should have only relevant changes.

@macbre macbre added the BLOCKED label Jun 3, 2021
@macbre macbre marked this pull request as draft June 3, 2021 11:20
@macbre
Copy link
Owner

macbre commented Jun 3, 2021 •
edited

Let's wait for #154 to be merged before this one - hence converted this PR to draft.

@tipanverella
Copy link

As a stargazer 😉 , I was wondering when this pull request was going to be scheduled.

@collerek
Copy link
Collaborator Author

collerek commented Jun 7, 2021

@tipanverella We need to merge #154 first. For me it's good to go but we are waiting for @macbre review.
All additional functionalities complicates the parser so it takes some time to understand and approve changes. :)
Hope @macbre will merge it soon.

@collerek collerek mentioned this pull request Jun 8, 2021
Closed
macbre
macbre reviewed Jun 8, 2021
View reviewed changes
.github/workflows/python-ci.yml Outdated
Comment on lines 71 to 72
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: poetry run coveralls --service=github
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that and thanks for fixing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries 🙂

@macbre macbre removed the BLOCKED label Jun 9, 2021
@macbre macbre marked this pull request as ready for review June 9, 2021 14:58
macbre
macbre approved these changes Jun 9, 2021
View reviewed changes
Copy link
Owner

@macbre macbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 🙂

@collerek @macbre
Update test/test_create_table.py
675478c 
Co-authored-by: Maciej Brencz <maciej.brencz@gmail.com>
@macbre macbre merged commit ab2422f into master Jun 9, 2021
@macbre macbre deleted the create_with branch June 9, 2021 15:10
@macbre
Copy link
Owner

macbre commented Jun 9, 2021

Closes #160 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macbre macbre macbre approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

The tables property is still having difficulties finding the tables in a CTAS
3 participants
@collerek @macbre @tipanverella