fix selected assets show up in different menus #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxuan-Yang <jiaxuan.yang@ibm.com>
JiaxuanYang
force-pushed
the
selected-assets
branch
from
74afc57
to
3183371
Compare
ckadner
added
UI
BluThaitanium
pushed a commit
to BluThaitanium/mlx
that referenced
this pull request
Jul 7, 2022
…ange#342) Signed-off-by: Jiaxuan-Yang <jiaxuan.yang@ibm.com> Signed-off-by: BluThaitanium <phuthai450@gmail.com>
BluThaitanium
pushed a commit
to BluThaitanium/mlx
that referenced
this pull request
Jul 7, 2022
…ange#342) Signed-off-by: Jiaxuan-Yang <jiaxuan.yang@ibm.com> Signed-off-by: BluThaitanium <phuthai450@gmail.com>
BluThaitanium
pushed a commit
to BluThaitanium/mlx
that referenced
this pull request
Jul 20, 2022
…ange#342) Signed-off-by: Jiaxuan-Yang <jiaxuan.yang@ibm.com> Signed-off-by: BluThaitanium <phuthai450@gmail.com>
mlx-bot-app bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
* Add dev doc links to CONTRIBUTING.md (#312) Resolves a task from #304 Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com> * Fixes the references to latest kfctl release (#311) Resolves a task from #304 Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com> * Do not verify links in project dependencies (#320) Resolves #319 Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Add navigation and description table of docs (#314) * Create readme for docs * Add description table to readme * Add links to table * update relative links * Change documentation to document Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com> * Add script to update the docs table (#317) Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com> * Modified the way sed version is set (#315) Instead of checking the operating system or shell emulator, test which version of `sed` is actually installed in the local environment. Resolves #301 Signed-off-by: Krishna Kumar <krishnakumar@ibm.com> * Bump waitress from 2.0.0 to 2.1.1 in /api/server (#321) Bumps [waitress](https://github.com/Pylons/waitress) from 2.0.0 to 2.1.1. - [Release notes](https://github.com/Pylons/waitress/releases) - [Changelog](https://github.com/Pylons/waitress/blob/master/CHANGES.txt) - [Commits](Pylons/waitress@v2.0.0...v2.1.1) --- updated-dependencies: - dependency-name: waitress dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump jupyter-server from 1.13.4 to 1.15.4 in /api/server (#324) Bumps [jupyter-server](https://github.com/jupyter/jupyter_server) from 1.13.4 to 1.15.4. - [Release notes](https://github.com/jupyter/jupyter_server/releases) - [Changelog](https://github.com/jupyter-server/jupyter_server/blob/main/CHANGELOG.md) - [Commits](jupyter-server/jupyter_server@v1.13.4...v1.15.4) --- updated-dependencies: - dependency-name: jupyter-server dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 in /dashboard/origin-mlx (#326) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump notebook from 6.4.8 to 6.4.10 in /api/server (#327) Bumps [notebook](http://jupyter.org) from 6.4.8 to 6.4.10. --- updated-dependencies: - dependency-name: notebook dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update API developer docs (#325) * Add codegen workflow diagram * Describe codegen workflow * Describe API server package modules Closes #325 Signed-off-by: Pavan Pss <psspavan96@gmail.com> Co-authored-by: Christian Kadner <ckadner@us.ibm.com> * Update UI developer docs (#323) Closes #323 Signed-off-by: RRM123 <rithikmamidi@gmail.com> * Correct description for make update_doc_table (#329) Signed-off-by: ezinneanne <onwukaezinneanne@gmail.com> * Update Kubernetes high version in deployment docs (#318) (#332) * Add Troubleshooting section * Limit K8s version for KIND cluster using `--image` flag Resolves #318 Signed-off-by: Kiran-Patel <kiran.patel@ibm.com> Signed-off-by: Kiran Patel 104844270+kiranp2396@users.noreply.github.com Signed-off-by: Christian Kadner <ckadner@us.ibm.com> Co-authored-by: Kiran-Patel <kiran.patel@ibm.com> Co-authored-by: Christian Kadner <ckadner@us.ibm.com> * fix errors in mlx-ui startup (#338) * Run mlx-ui as non-root user (#339) Closes #337 Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Update MLX setup instructions for KF 1.5 (#346) * Update MLX setup instructions for KF 1.5 Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * fix selected assets show up in different menus (#342) Signed-off-by: Jiaxuan-Yang <jiaxuan.yang@ibm.com> * Consolidate readme (#356) Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com> Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com> Co-authored-by: Rafael Vasquez <rafael.vasquez@ryerson.com> * Document MLX Models Workshop (#352) Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Add GitHub action to verify doc links (#357) Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com> Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com> Signed-off-by: Christian Kadner <ckadner@us.ibm.com> Signed-off-by: Krishna Kumar <krishnakumar@ibm.com> Signed-off-by: RRM123 <rithikmamidi@gmail.com> Signed-off-by: ezinneanne <onwukaezinneanne@gmail.com> Signed-off-by: Jiaxuan-Yang <jiaxuan.yang@ibm.com> Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com> Co-authored-by: Rafael Vasquez <rafael.vasquez@ryerson.ca> Co-authored-by: Krishna Kumar Ramachandran <krishnakumar@gatech.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pavan Pss <psspavan96@gmail.com> Co-authored-by: RRM123 <40575227+rrm123@users.noreply.github.com> Co-authored-by: Ezinne Anne Emilia <onwukaezinneanne@gmail.com> Co-authored-by: Kiran Patel <104844270+kiranp2396@users.noreply.github.com> Co-authored-by: Kiran-Patel <kiran.patel@ibm.com> Co-authored-by: jbusche <101845348+jbusche@users.noreply.github.com> Co-authored-by: Joanna <Jiaxuan.Yang@ibm.com> Co-authored-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #263
When the user switches to a different asset page, they should see zero assets of that type selected.