Modified the way sed version is set

[krishnakumar27]

#301

Updated the way sed is called depending on whether it was a MacOS version or BSD version of sed

@ckadner FYI

[ckadner]

Thank you Krishna, did you test the two scripts?

• for codegen.sh run it on the main repo clone and on the clone of your forks with the changes and use a file/directory comparison tool to make sure the outcome is the same before and after your changes. Running generate_code.sh (which is calling codegen.sh) should produce no changes (git status -> clean)
• for add_license_header.sh, same thing, clone main repo and compare to your changed script. Here you would remove license header from a Python script, a JavaScript, a HTML, a YAML file and see it gets generated correctly

[ckadner]

Oh, and you need to sign-off your commits to make the DCO checks pass :-)

[krishnakumar27]

@ckadner I have tested both the scripts in both linux and mac. They seem to work as expected.

[ckadner]

Thanks @krishnakumar27

[mlx-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, krishnakumar27

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ckadner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ckadner]

Please fix the failing DCO check by (squashing and) signing your commits.

[krishnakumar27]

@ckadner I just did the DCO signoff

[ckadner]

Hi @krishnakumar27 -- I see a lot of unrelated commits in your PR since you used your forks main branch for your changes and then later merged the upstream main. I don't want to merge all of those other commits. Could you roll back your merge commits, i.e. git reset HEAD~10 (go 10 commits back), undo all of the other changes that aren't yours commit only your changes and then instead of doing merges, do a rebase the changes you made for this PR in your forks main? Though it looks like your actual code changes are in a commit somewhere in the middle of the 9 unrelated commits, so it might be easier to close this PR and create a new PR from a new feature branch (created after you update your forks main with the upstream main.

[ckadner]

Hi @krishnakumar27 -- I resolved the merge conflict and did a dry-run to test squashing-merging your PR. Seems Github figured out that only 2 files were changed. So all is good. Please create a feature branch for your next contribution instead of committing directly to the main branch of your mlx fork :-)

[ckadner]

/lgtm

[krishnakumar27]

@ckadner Alright, yeah I was working with a feature branch in my fork, but I merged it to my main before creating a PR. I will create a PR directly from there the next time. Thank you