-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Handlebars' parser API #186
Comments
Hi, i started working on this here. |
Nice! I see that you advanced a lot, can't wait to test it 👍 I was aware of the changes on the commit history, but I haven't really gotten into how AST works (what the parameters for the nodes are, for example) nor do I understood how to apply those changes on the emblem grammar, so I'm not very confident about contributing. |
Tested your changes in my project and the parsing worked perfectly so far, the htmlbars precompiler didn't complain and the templates worked on the latest ember release. Only caveat was using the Sill, looks like some libraries aren't htmlbars ready yet so what I could test was limited. I'll keep trying tho :) |
Closing this since we're not targeting Hbs AST any more; I'm finishing up work on an Emblem->Handlebars source compiler that'll take care of all of this |
In relation to #139, I was trying to make an Ember project work with tildeio/htmlbars + emblem, but came to realize that htmlbars is using the new parser API discussed on handlebars-lang/handlebars.js#889
Given that, the AST provided by emblem is currently incompatible with htmlbars because some (minor, I think) changes on this new API.
I wouldn't mind trying to adapt emblem to the new API, but I'm not really sure were to start, would you mind giving me some pointers?
The text was updated successfully, but these errors were encountered: