Lifesteal enchant breaks drop rate

[Xetaxheb]

Tested in TNP Limitless 3 Limitless 3 - v1.9.9b
Version Ma-Enchants-1.16.3-3.5.0.jar

It completely removes ability for killed slimes to drop reliquary slime pearls, probably all reliquary items, seems to nerf drop rates despite overcapped looting/scavenger enchants (vanilla/apotheosis)

Not sure what else.. definitely this enchant though. Using it on silents gear swords.

[Xetaxheb]

After using my weapons without it, I can say it significantly screws up drop rates on many many things. The main thing that somehow sneaks by is elementalcraft shards. Most other drops seem to be significantly lowered or outright removed.

[DerekM07]

I noticed the same thing with Ma-Enchants and Reliquary and assumed it was because lifesteal and sweeping edge were incompatible together. I didn't test extensively, but I believe that only the primary target was counting as a player kill and thus qualifying for the Reliquary drop chance.

[Lukasz4598PL]

it doesn't seem to totaly remove drops,I killed five enderman and got nothing after that i killed a few more and got normal drops
.

[SiverDX]

My assumption is that this is the problem (if the damage kills the mob):

Ma-Enchants/src/main/java/com/maciej916/maenchants/common/handler/HandlerLifesteal.java

Line 27 in 383b869

entity.hurt(DamageSource.GENERIC, damage*1.5f);

This also breaks the Wisdom enchant of this mod:

Ma-Enchants/src/main/java/com/maciej916/maenchants/common/handler/HandlerWisdom.java

Line 13 in 383b869

if (event.getEntity() != event.getAttackingPlayer()) return;

I'm not sure why Lifesteal deals extra damage but DamageSource.playerAttack(player) should maybe be used instead