-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rc<T> and Arc<T> sources #340
Conversation
Nice @InfiniteCoder01! Running the checks, can you update the code to make all tests pas? |
@jeertmans, sorry for not reading feature list properly. Now I've fixed it (I don't think |
Thanks @InfiniteCoder01! Could you please add one or two tests, and a docstring on top of each class, to show very basic examples? |
I don't see any tests for implementation of |
@InfiniteCoder01 Did you check https://github.com/maciejhirsz/logos/blob/master/logos/src/source.rs? It contains implementation of |
Those are implementations, but there are no docs, nor tests for them (docs only for Source trait). But there is a module-level doc comment where I've added new sources. |
True, but that's not because there is no documentation at the moment that it isn't worth adding some :-) |
In rust, you can't add docs to |
Can't really add tests until #341 |
oh yeah, you've got a good point! Looking at your code, I actually wonder if it just makes sense to rather implement |
@InfiniteCoder01 hello! It will be cool to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented this for Rc
and Arc
using a single impl
block:
//! * `Source` - implemented by default for `&str`, `&[u8]` and wrapper types, used by the `Lexer`.
...
#[cfg(feature = "std")]
impl<T> Source for T
where
T: Deref,
<T as Deref>::Target: Source,
{
type Slice<'a> = <T::Target as Source>::Slice<'a>
where T: 'a;
fn len(&self) -> usize {
self.deref().len()
}
fn read<'a, Chunk>(&'a self, offset: usize) -> Option<Chunk>
where
Chunk: self::Chunk<'a>,
{
self.deref().read(offset)
}
...
}
@InfiniteCoder01 hello! It will be cool to add Box.
Box
also implements Deref
, so the impl above covers it too.
I tried using impl<T, Inner> Source for T
where
T: AsRef<Inner>,
Inner: Source,
{
|
Makes sense, thank you! @InfiniteCoder01 Could you please update your branch with respect to the master and resolve conflicts? So I can merge it :) |
Sorry for closing the PR, I'm still bad at git stuff. Should work now, tested with |
No issue, thanks for replying so quickly @InfiniteCoder01! Running CI, it seems that you should run |
Thank you for your contribution! |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [logos](https://logos.maciej.codes/) ([source](https://togithub.com/maciejhirsz/logos)) | dependencies | patch | `0.14.0` -> `0.14.1` | --- ### Release Notes <details> <summary>maciejhirsz/logos (logos)</summary> ### [`v0.14.1`](https://togithub.com/maciejhirsz/logos/releases/tag/v0.14.1): 0.14.1 - Debug feature and fixes #### What's Changed - fix(doc): reset logos2 to logos by [@​jeertmans](https://togithub.com/jeertmans) in [maciejhirsz/logos#372 - chore(book): add JSON-borrowed parser example by [@​jeertmans](https://togithub.com/jeertmans) in [maciejhirsz/logos#373 - Add Rc<T> and Arc<T> sources by [@​InfiniteCoder01](https://togithub.com/InfiniteCoder01) in [maciejhirsz/logos#340 - Fix unicode dot by [@​RustyYato](https://togithub.com/RustyYato) in [maciejhirsz/logos#376 - chore(docs): cleanup examples by [@​jeertmans](https://togithub.com/jeertmans) in [maciejhirsz/logos#381 - chore(lib): add debug feature by [@​jeertmans](https://togithub.com/jeertmans) in [maciejhirsz/logos#382 - Cleanup unused Source features by [@​kmicklas](https://togithub.com/kmicklas) in [maciejhirsz/logos#335 - chore(deps): bump peaceiris/actions-mdbook from 1 to 2 by [@​dependabot](https://togithub.com/dependabot) in [maciejhirsz/logos#387 - Fix `Lexer::clone` leak and UB + tests by [@​Jakobeha](https://togithub.com/Jakobeha) in [maciejhirsz/logos#390 - fix(lib): correctly handle miss for loop in loop by [@​lukas-code](https://togithub.com/lukas-code) in [maciejhirsz/logos#393 - chore(lib): remove error branch from LUT if it is unreachable by [@​RustyYato](https://togithub.com/RustyYato) in [maciejhirsz/logos#386 - fix(docs): typo by [@​joerivanruth](https://togithub.com/joerivanruth) in [maciejhirsz/logos#396 - chore(docs): Adds graph debug documentation to book by [@​afreeland](https://togithub.com/afreeland) in [maciejhirsz/logos#379 - chore: drop python linting frmo pre-commit-config by [@​LeoDog896](https://togithub.com/LeoDog896) in [maciejhirsz/logos#403 - refactor: don't use deprecated max_value() method by [@​LeoDog896](https://togithub.com/LeoDog896) in [maciejhirsz/logos#404 - chore(version): bump logos version to 0.14.1 by [@​jeertmans](https://togithub.com/jeertmans) in [maciejhirsz/logos#409 - fix(docs): change old 0.14.0 by [@​jeertmans](https://togithub.com/jeertmans) in [maciejhirsz/logos#410 #### New Contributors - [@​InfiniteCoder01](https://togithub.com/InfiniteCoder01) made their first contribution in [maciejhirsz/logos#340 - [@​RustyYato](https://togithub.com/RustyYato) made their first contribution in [maciejhirsz/logos#376 - [@​Jakobeha](https://togithub.com/Jakobeha) made their first contribution in [maciejhirsz/logos#390 - [@​lukas-code](https://togithub.com/lukas-code) made their first contribution in [maciejhirsz/logos#393 - [@​joerivanruth](https://togithub.com/joerivanruth) made their first contribution in [maciejhirsz/logos#396 - [@​afreeland](https://togithub.com/afreeland) made their first contribution in [maciejhirsz/logos#379 - [@​LeoDog896](https://togithub.com/LeoDog896) made their first contribution in [maciejhirsz/logos#403 **Full Changelog**: maciejhirsz/logos@v0.14...v0.14.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/akrantz01/antsi). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
No description provided.