Implement service resource and data source in the framework provider

[tosuke]

Output from acceptance testing:

$ MACKEREL_EXPERIMENTAL_TFFRAMEWORK=1 make testacc TESTS='"^TestAcc(DataSourceMackerelService(NotMatchAnyService)?|MackerelService)$$"'
TF_ACC=1 go test -v ./mackerel/... -run "^TestAcc(DataSourceMackerelService(NotMatchAnyService)?|MackerelService)$" -timeout 120m
2024/06/12 11:54:56 [INFO] mackerel: use terraform-plugin-framework based implementation
=== RUN   TestAccDataSourceMackerelService
=== PAUSE TestAccDataSourceMackerelService
=== RUN   TestAccDataSourceMackerelServiceNotMatchAnyService
=== PAUSE TestAccDataSourceMackerelServiceNotMatchAnyService
=== RUN   TestAccMackerelService
=== PAUSE TestAccMackerelService
=== CONT  TestAccDataSourceMackerelService
=== CONT  TestAccMackerelService
=== CONT  TestAccDataSourceMackerelServiceNotMatchAnyService
--- PASS: TestAccDataSourceMackerelServiceNotMatchAnyService (2.47s)
--- PASS: TestAccDataSourceMackerelService (5.17s)
--- PASS: TestAccMackerelService (8.64s)
PASS
ok      github.com/mackerelio-labs/terraform-provider-mackerel/mackerel 9.407s

[Arthur1]

The review is in process, but I have commented tentatively. I completed the review and made some minor suggestions.

Since we merged another pull request, could you fix conflict?

[Arthur1]

[may] Compiling regexp needs some initialize cost, so store the compiled expression as a global parameter is desirable.

var re = regexp.MustCompile(`^[a-zA-Z0-9][a-zA-Z0-9-_]+$`

func ServiceNameValidator() validator.String {
	return stringvalidator.All(
		stringvalidator.LengthBetween(2, 63),
		stringvalidator.RegexMatches(re, "..."),
	)
}

[tosuke]

As ServiceNameValidator is expected to be called constant times during a provider initialization, hoisting regex compilation may not be necessary. But it is some kind of best practices and there is no reason to deviate it: 91ffd1d

[Arthur1]

so cute lol

[Arthur1]

[memo] Former schema is here.

terraform-provider-mackerel/mackerel/data_source_mackerel_service.go

Lines 11 to 26 in 73005a2

	func dataSourceMackerelService() *schema.Resource {
	return &schema.Resource{
	ReadContext: dataSourceMackerelServiceRead,
	Schema: map[string]*schema.Schema{
	"name": {
	Type: schema.TypeString,
	Required: true,
	},
	"memo": {
	Type: schema.TypeString,
	Computed: true,
	},
	},
	}
	}

Why memo has been treated as computed attribute?

[tosuke]

Computed attributes are "output" from the provider.
We can use memo without specifying the value explicitly (an example below), so memo(and id) is a computed attribute.

data "mackerel_service" "svc" {
  name = "service"
}
resource "some_resource" "something" {
  some_value = data.mackerel_service.svc.memo
}

[tosuke]

id may be used "input" value in the future (then name and memo are "output"). But it is out of scope.

[Arthur1]

I understood that the computed attribute would be unnecessary if the datasource could take a memo as input. Thank you for the information.

[Arthur1]

Thank you.