Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does tier price importer plugin work with Magento 2? #20

Closed
NudeWeb opened this issue Jan 17, 2018 · 13 comments
Closed

Does tier price importer plugin work with Magento 2? #20

NudeWeb opened this issue Jan 17, 2018 · 13 comments

Comments

@NudeWeb
Copy link

NudeWeb commented Jan 17, 2018

Has anyone got a wroking version for Magento 2 to import tier/group prices?

@Boyd1e
Copy link

Boyd1e commented Jul 25, 2018

yes tier pricing is working, I have put in the change to make it work
https://github.com/Boyd1e/magmi-m2

@simonrl
Copy link

simonrl commented Oct 8, 2018

Hi, it does not work for me. Can you post the code of your change so I can have a look at it? Using Magento 2.2.5

@Boyd1e
Copy link

Boyd1e commented Oct 8, 2018

its been a while i think it was this:

/magmi/plugins/extra/itemprocessors/tierprice

Line 168
change "core_store" to "store"

save changes

@simonrl
Copy link

simonrl commented Oct 8, 2018

great, this was it - thanks!

as a side note, I replaced core_store everywhere in magmi and dropdown attribute import worked afterwards (also didn't work before).

@Boyd1e
Copy link

Boyd1e commented Oct 8, 2018

That's good news! Glad I could help! :)

@tmotyl
Copy link
Member

tmotyl commented Oct 8, 2018

@Boyd1e can you please provide a pull request? I would like to include your change.
Thanks

@Boyd1e
Copy link

Boyd1e commented Oct 8, 2018

Can't say I have ever submitted anything to github (I signed up to share this), I have however submitted a commit a few minutes ago if that works?

@tmotyl
Copy link
Member

tmotyl commented Oct 17, 2018

Hi @Boyd1e there was sth wrong with the PR you've send (there were tons of commits). Please try again, or paste a link to a commit in your repo which fixes the problem.

@tmotyl
Copy link
Member

tmotyl commented Oct 17, 2018

@simonrl Sounds like you have fixed some other places too. Can you send a PR? thanks

@simonrl
Copy link

simonrl commented Oct 18, 2018

@tmotyl yes i can fork & provide a PR on Sunday.

@tmotyl
Copy link
Member

tmotyl commented Oct 19, 2018

awesome, thanks!

@mflasquin
Copy link

Hi, can you please provide the pr for this issue ?

mflasquin pushed a commit to mflasquin/magmi-m2 that referenced this issue Mar 24, 2020
tmotyl pushed a commit that referenced this issue Mar 25, 2020
Co-authored-by: Maxime Flasquin <maxime.flasquin@easycom.digital>
@tmotyl
Copy link
Member

tmotyl commented Mar 25, 2020

I've just merged the change, so closing the issue.

@tmotyl tmotyl closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants