Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nondistributable archives #9

Merged
merged 3 commits into from
Dec 7, 2018

Conversation

ryandesign
Copy link
Contributor

This PR enhances mpbb to also handle uploading nondistributable archives to a private server, and to consider the availability of those nondistributable archives when deciding whether to build a port, and making those nondistributable archives available to be installed by MacPorts when using mpbb.

See https://trac.macports.org/ticket/54800.

These modifications are untested.

Any comments about the approach, or anything you'd like to see done differently?

@ryandesign
Copy link
Contributor Author

The corresponding changes to the buildbot master.cfg are in macports/macports-infrastructure#8.

@mojca
Copy link
Member

mojca commented Nov 29, 2018

Thank you very much for addressing this. (No particular comment or complained about the code. From the first sight it looks reasonable.)

@ryandesign
Copy link
Contributor Author

Note that I should be the one to merge this, when we decide it's ready, so that I can make sure the buildmaster is turned off first, so that I can deploy the new configuration there.

mpbb-checkout Outdated
@@ -190,6 +198,7 @@ checkout() {
# Do not edit !!!
sources_conf ${option_work_dir}/sources.conf
host_blacklist *.distfiles.macports.org *.packages.macports.org
archive_site_local ${option_archive_sites}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had tested archive_site_local on my system, but I was doing it wrong. Turns out it doesn't work at all; it's been broken for years. That bug in base will need to be fixed, and the one that doesn't allow multiple URLs in archive_site_local. And mpbb-checkout will need to be changed to append :tbz2 to each URL.

@ryandesign ryandesign merged commit 3994fd1 into macports:master Dec 7, 2018
@ryandesign ryandesign deleted the private-archives branch December 7, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants