-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbled text with ligature font #841
Comments
Hmm I’ll need to take a look. Coincidentally I was wondering whether people use the ligature feature. Now I know. |
I can confirm this issue with another font (PragmataPro). Check this screen recording. |
@zrzka It could be related but it's a different problem. And I believe MacVim was always like that when the cursor is on the line with ligature the ligature breaks up into components and then assembles back again. But the space taken by the ligature remains the same. In this particular issue the ligature takes half of the horizontal space and thus the next letter overlaps with the ligature. |
@eirnym Fira Code is not monospaced. Fixedsys emulates monospacingness (:-)) by clever geometry in the font metrics, and it works everywhere, except MacVim, Windows Powershell and Linux |
This is late, but is this issue still there? I would imagine it should have been fixed but i never got around to circling back to this. @kika |
@ychin I'm on 9.0.472 now and the problem is gone. |
I have a font I can't live without (some form of psychotic disability I guess) - Fixedsys
MacVim is the only editor I use and once I noticed that it supports ligatures I started working on the font (I didn't do the whole font, only added programming ligatures). Everything was nice and easy until
snapshot-147
which broke these ligatures. Nowa>=b
looks like instead of(the vertical alignment is fine, it's just my screenshotting abilities).
The change that ruined it is this: ee668a4 by @ichizok
I tried to debug this for a couple of days, but my understanding of CoreText is close to zero and I'm mostly wandering around printing different things. There's of course a possibility that there's something wrong with the font itself, but it works everywhere else (except for Konsole in Arch Linux, which is a known issue and in Windows Powershell), at least on MacOS. It works in TextEdit, which I suppose is a "reference implementation" of CoreText based editor.
I'm willing to invest some more time with proper guidance from someone who knows how all of this works. For now, the workaround is just take
MMCoreTextView.m
fromsnapshot-146
and slap it into thesnapshot-153
source tree and rebuild. Works for me, but this is stupid.Relevant issue from the font repository: kika/fixedsys#16
The text was updated successfully, but these errors were encountered: