Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbled text with ligature font #841

Closed
kika opened this issue Feb 4, 2019 · 7 comments
Closed

Garbled text with ligature font #841

kika opened this issue Feb 4, 2019 · 7 comments
Labels
Renderer Text rendering issues, including CoreText renderer Response Needed Issues / PRs marked with this will be automatically closed in 45 days unless it receives an update

Comments

@kika
Copy link

kika commented Feb 4, 2019

I have a font I can't live without (some form of psychotic disability I guess) - Fixedsys
MacVim is the only editor I use and once I noticed that it supports ligatures I started working on the font (I didn't do the whole font, only added programming ligatures). Everything was nice and easy until snapshot-147 which broke these ligatures. Now a>=b looks like badliga instead of goodliga
(the vertical alignment is fine, it's just my screenshotting abilities).

The change that ruined it is this: ee668a4 by @ichizok

I tried to debug this for a couple of days, but my understanding of CoreText is close to zero and I'm mostly wandering around printing different things. There's of course a possibility that there's something wrong with the font itself, but it works everywhere else (except for Konsole in Arch Linux, which is a known issue and in Windows Powershell), at least on MacOS. It works in TextEdit, which I suppose is a "reference implementation" of CoreText based editor.

I'm willing to invest some more time with proper guidance from someone who knows how all of this works. For now, the workaround is just take MMCoreTextView.m from snapshot-146 and slap it into the snapshot-153 source tree and rebuild. Works for me, but this is stupid.

Relevant issue from the font repository: kika/fixedsys#16

@ychin ychin added the Renderer Text rendering issues, including CoreText renderer label Feb 4, 2019
@ychin
Copy link
Member

ychin commented Feb 4, 2019

Hmm I’ll need to take a look. Coincidentally I was wondering whether people use the ligature feature. Now I know.

@zrzka
Copy link

zrzka commented Mar 6, 2019

I can confirm this issue with another font (PragmataPro). Check this screen recording.

@kika
Copy link
Author

kika commented Mar 6, 2019

@zrzka It could be related but it's a different problem. And I believe MacVim was always like that when the cursor is on the line with ligature the ligature breaks up into components and then assembles back again. But the space taken by the ligature remains the same. In this particular issue the ligature takes half of the horizontal space and thus the next letter overlaps with the ligature.

@eirnym
Copy link
Contributor

eirnym commented Mar 19, 2019

@kika I have Fira Code Light:12 set and have no such problem. Could you try this font to check if you can reproduce?

@zrzka it was all the time and I somewhat agree with that as I see it as a minor problem.

@kika
Copy link
Author

kika commented Mar 20, 2019

@eirnym Fira Code is not monospaced. Fixedsys emulates monospacingness (:-)) by clever geometry in the font metrics, and it works everywhere, except MacVim, Windows Powershell and Linux konsole.

@ychin
Copy link
Member

ychin commented Oct 19, 2022

This is late, but is this issue still there? I would imagine it should have been fixed but i never got around to circling back to this. @kika

@ychin ychin added the Response Needed Issues / PRs marked with this will be automatically closed in 45 days unless it receives an update label Oct 19, 2022
@kika
Copy link
Author

kika commented Oct 19, 2022

@ychin I'm on 9.0.472 now and the problem is gone.

@kika kika closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Renderer Text rendering issues, including CoreText renderer Response Needed Issues / PRs marked with this will be automatically closed in 45 days unless it receives an update
Projects
None yet
Development

No branches or pull requests

4 participants