Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uart #40

Merged
merged 32 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@madcowswe
Copy link
Owner

commented Oct 15, 2017

Implements #39 (UART Communication)

UART comms at 115200, same command-set as USB, but with two added framing characters (Described in README).

Things to review:

  • Communication works as expected, both on UART and USB
  • Step/dir still works when configured as such
  • Documentation is clear

@madcowswe madcowswe requested a review from Wetmelon Oct 15, 2017

@CLAassistant

This comment has been minimized.

Copy link

commented Oct 15, 2017

CLA assistant check
All committers have signed the CLA.

README.md Outdated
@@ -118,7 +127,13 @@ Setup instructions as follows:
* Run test_bulk.py

### Command set
The most accurate way to understand the commands is to read [the code](https://github.com/madcowswe/ODriveFirmware/blob/f19f1b78de4bd917284ff95bc61ca616ca9bacc4/MotorControl/low_level.c#L353) that parses the commands.
The most accurate way to understand the commands is to read [the code](https://github.com/madcowswe/ODriveFirmware/blob/f19f1b78de4bd917284ff95bc61ca616ca9bacc4/MotorControl/vommands.c#L133) that parses the commands. Nevertheless, here is an overview:

This comment has been minimized.

Copy link
@Wetmelon

Wetmelon Oct 15, 2017

Collaborator

Typo. vommands.c -> commands.c

Also, this should probably use the branch name and not a random commit. Correct line: https://github.com/madcowswe/ODriveFirmware/blob/master/MotorControl/commands.c#L133

Wetmelon and others added some commits Oct 15, 2017

Fix link to commands.c
Fix typo vommands.c -> commands.c, also use branch name instead of commit hash

Wetmelon and others added some commits Oct 19, 2017

@madcowswe madcowswe merged commit af3c646 into devel Oct 31, 2017

1 check passed

license/cla Contributor License Agreement is signed.
Details

@madcowswe madcowswe deleted the uart branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.