Uart #40
Merged
Uart #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Wetmelon
reviewed
Oct 15, 2017
README.md
Outdated
| @@ -118,7 +127,13 @@ Setup instructions as follows: | |||
| * Run test_bulk.py | |||
|
|
|||
| ### Command set | |||
| The most accurate way to understand the commands is to read [the code](https://github.com/madcowswe/ODriveFirmware/blob/f19f1b78de4bd917284ff95bc61ca616ca9bacc4/MotorControl/low_level.c#L353) that parses the commands. | |||
| The most accurate way to understand the commands is to read [the code](https://github.com/madcowswe/ODriveFirmware/blob/f19f1b78de4bd917284ff95bc61ca616ca9bacc4/MotorControl/vommands.c#L133) that parses the commands. Nevertheless, here is an overview: | |||
There was a problem hiding this comment.
Typo. vommands.c -> commands.c
Also, this should probably use the branch name and not a random commit. Correct line: https://github.com/madcowswe/ODriveFirmware/blob/master/MotorControl/commands.c#L133
Fix typo vommands.c -> commands.c, also use branch name instead of commit hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #39 (UART Communication)
UART comms at 115200, same command-set as USB, but with two added framing characters (Described in README).
Things to review: