Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further issues in builds of other SUSY processes #820

Closed
valassi opened this issue Mar 3, 2024 · 1 comment · Fixed by #824
Closed

Further issues in builds of other SUSY processes #820

valassi opened this issue Mar 3, 2024 · 1 comment · Fixed by #824
Assignees

Comments

@valassi
Copy link
Member

valassi commented Mar 3, 2024

The builds for one simple process gg>tt~ in the SUSY model is now fixed by PR #625 (for both HRDCOD=0 and HRDCOD=1).

I tried to investigate a few more SUSY processes, and unfortunately I still found other issues (which sometimes look very similar to those I already fixed).

  • In "'import model MSSM_SLHA2; generate g g > t t~ t t~", both builds succeed, Strangely however the ME results are different in HRDCOD=1 with respect to the reference file produced with HRDCOD=0
  ME  4.578319386090301e-08
r.ME  4.847626218542335e-08
  • In "import model MSSM_SLHA2; define q = u c d s u~ c~ d~ s~; generate g q > t t~ q", the HRDCOD=0 and HRDCOD=1 builds succeed and give the same results as each other. This is true in both P1 subdirectories.

  • In "import model MSSM_SLHA2; generate g g > go go", the HRDCOD=1 build succeeds, but the HRDCOD=0 build fails

    ccache g++  -O3  -std=c++17 -I. -I../../src -Wall -Wshadow -Wextra -ffast-math  -fopenmp  -march=skylake-avx512 -mprefer-vector->
    CPPProcess.cc: In member function ‘virtual void mg5amcCpu::CPPProcess::initProc(const string&)’:
    CPPProcess.cc:554:38: error: ‘class mg5amcCpu::Parameters_MSSM_SLHA2’ has no member named ‘mdl_bsmIndepParam’; did you mean ‘nBs>
      554 |       memcpy( bsmIndepParam, m_pars->mdl_bsmIndepParam, Parameters_MSSM_SLHA2::nBsmIndepParam * sizeof( double ) );
          |                                      ^~~~~~~~~~~~~~~~~
          |                                      nBsmIndepParam
  • In "import model MSSM_SLHA2; generate g g > t1 t1~", HRDCOD=0 builds fail
ccache g++  -O3  -std=c++17 -I.  -fPIC -Wall -Wshadow -Wextra -ffast-math  -fopenmp  -march=skylake-avx512 -mprefer-vector-width=256  -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_FPTYPE2_DOUBLE -fPIC -c Parameters_MSSM_SLHA2.cc -o Parameters_MSSM_SLHA2.o
In file included from Parameters_MSSM_SLHA2.cc:15:
Parameters_MSSM_SLHA2.h: In function ‘const mg5amcCpu::Parameters_MSSM_SLHA2_dependentCouplings::DependentCouplings_sv mg5amcCpu::Parameters_MSSM_SLHA2_dependentCouplings::computeDependentCouplings_fromG(const fptype_sv&, const double*)’:
Parameters_MSSM_SLHA2.h:835:33: error: ‘mdl_I51x33’ was not declared in this scope
  835 |         out.GC_55 = -( cI * G * mdl_I51x33 ) - cI * G * mdl_I52x33;
      |                                 ^~~~~~~~~~
Parameters_MSSM_SLHA2.h:835:57: error: ‘mdl_I52x33’ was not declared in this scope
  835 |         out.GC_55 = -( cI * G * mdl_I51x33 ) - cI * G * mdl_I52x33;
      |                                                         ^~~~~~~~~~
Parameters_MSSM_SLHA2.h:836:33: error: ‘mdl_I51x36’ was not declared in this scope
  836 |         out.GC_57 = -( cI * G * mdl_I51x36 ) - cI * G * mdl_I52x36;
      |                                 ^~~~~~~~~~
Parameters_MSSM_SLHA2.h:836:57: error: ‘mdl_I52x36’ was not declared in this scope
  836 |         out.GC_57 = -( cI * G * mdl_I51x36 ) - cI * G * mdl_I52x36;
      |                                                         ^~~~~~~~~~
Parameters_MSSM_SLHA2.h:837:42: error: ‘mdl_I74x33’ was not declared in this scope
  837 |         out.GC_90 = cI * mdl_G__exp__2 * mdl_I74x33 + cI * mdl_G__exp__2 * mdl_I75x33;
      |                                          ^~~~~~~~~~
Parameters_MSSM_SLHA2.h:837:76: error: ‘mdl_I75x33’ was not declared in this scope
  837 |         out.GC_90 = cI * mdl_G__exp__2 * mdl_I74x33 + cI * mdl_G__exp__2 * mdl_I75x33;
      |                                                                            ^~~~~~~~~~
  • In "import model MSSM_SLHA2; generate g g > t1 t1~", HRDCOD=1 builds also fail
ccache /usr/local/cuda-12.0/bin/nvcc   -Xcompiler -O3 -lineinfo -I. -I../../src -I/usr/local/cuda-12.0/include/ -DUSE_NVTX -gencode arch=compute_70,code=compute_70 -gencode arch=compute_70,code=sm_70 -use_fast_math -std=c++17  -ccbin /usr/lib64/ccache/g++ -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_FPTYPE2_DOUBLE -DMGONGPU_HARDCODE_PARAM -Xcompiler -fPIC -c -x cu Parameters_MSSM_SLHA2.cc -o Parameters_MSSM_SLHA2_cu.o
Parameters_MSSM_SLHA2.h(835): error: no operator "*" matches these operands
            operand types are: thrust::complex<double> * const mgOnGpu::cxsmpl<double>

Parameters_MSSM_SLHA2.h(835): error: no operator "*" matches these operands
            operand types are: thrust::complex<double> * const mgOnGpu::cxsmpl<double>

Parameters_MSSM_SLHA2.h(836): error: no operator "*" matches these operands
            operand types are: thrust::complex<double> * const mgOnGpu::cxsmpl<double>

Parameters_MSSM_SLHA2.h(836): error: no operator "*" matches these operands
            operand types are: thrust::complex<double> * const mgOnGpu::cxsmpl<double>

Parameters_MSSM_SLHA2.h(837): error: no operator "*" matches these operands
            operand types are: thrust::complex<double> * const mgOnGpu::cxsmpl<double>

Parameters_MSSM_SLHA2.h(837): error: no operator "*" matches these operands
            operand types are: thrust::complex<double> * const mgOnGpu::cxsmpl<double>
  • In "import model MSSM_SLHA2; generate g g > ul ul~", code generation fails
  File "/data/avalassi/GPU2023/madgraph4gpuBis/MG5aMC/mg5amcnlo/PLUGIN/CUDACPP_OUTPUT/model_handling.py", line 1543, in super_write_p
rocess_cc_file
    replace_dict = super(PLUGIN_export_cpp.OneProcessExporterGPU, self).write_process_cc_file(False)
  File "/data/avalassi/GPU2023/madgraph4gpuBis/MG5aMC/mg5amcnlo/madgraph/iolibs/export_cpp.py", line 785, in write_process_cc_file
    self.get_process_function_definitions()
  File "/data/avalassi/GPU2023/madgraph4gpuBis/MG5aMC/mg5amcnlo/PLUGIN/CUDACPP_OUTPUT/model_handling.py", line 1154, in get_process_f
unction_definitions
    params[pos] = para
IndexError: list assignment index out of range

I suggest that PR #625 can be merged first, and these issues investigated later on.

@valassi valassi self-assigned this Mar 3, 2024
@valassi valassi changed the title Further issues in builds of other SUSY processes ( Further issues in builds of other SUSY processes Mar 3, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this issue Mar 8, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this issue Mar 8, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this issue Mar 8, 2024
…5#820

Now HRDCOD=0 builds of susy_gg_gogo.sa are successful and runTest.exe succeeds against the HRDCOD=1 reference
valassi added a commit to valassi/madgraph4gpu that referenced this issue Mar 8, 2024
…HRDCOD=0 builds madgraph5#820

Now HRDCOD=0 builds of susy_gg_gogo.sa are successful and runTest.exe succeeds against the HRDCOD=1 reference
valassi added a commit to valassi/madgraph4gpu that referenced this issue Mar 8, 2024
@valassi
Copy link
Member Author

valassi commented Mar 8, 2024

I think I have essentially fixed all of these issues. Now cross checking them one by one.

  • In "'import model MSSM_SLHA2; generate g g > t t~ t t~", both builds succeed, Strangely however the ME results are different in HRDCOD=1 with respect to the reference file produced with HRDCOD=0

This is fixed. The HRDCOD=1 results were right, the HRDCOD=0 results were wrong but are now fixed (some value assignments were missing).

  • In "import model MSSM_SLHA2; generate g g > go go", the HRDCOD=1 build succeeds, but the HRDCOD=0 build fails

This is also fixed

  • In "import model MSSM_SLHA2; generate g g > t1 t1~", HRDCOD=0 builds fail
  • In "import model MSSM_SLHA2; generate g g > t1 t1~", HRDCOD=1 builds also fail

These are also fixed. Since this is a true and simple SUSY process, I aded this to the repo (and I removed susy_gg_tt, which just includes susy contrubtions to an existing SM process)

  • In "import model MSSM_SLHA2; generate g g > ul ul~", code generation fails

This is also fixed.

All codegen, builds and basic tests for the processes above are all succeeding and giving internally consistent results.

--

Summary: this is fixed in PR #824 - closing for simplicity

@valassi valassi closed this as completed Mar 8, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant